Skip to content

[release/9.0] Mark Aspire.Hosting.Python as experimental #6460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joperezr merged 4 commits into from
Oct 25, 2024
Merged

[release/9.0] Mark Aspire.Hosting.Python as experimental #6460

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
782aaab
Mark Aspire.Hosting.Python as experimental
sebastienros Oct 22, 2024
32aaab1
PR feedbcak
sebastienros Oct 23, 2024
b1549df
Move suppression to csproj
sebastienros Oct 23, 2024
4e95808
Remove stable flag from csproj
sebastienros Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Mark Aspire.Hosting.Python as experimental 
Fixes #6298
  • Loading branch information
@sebastienros
sebastienros authored and github-actions committed Oct 23, 2024
commit 782aaab60dd471db7e1608b80cee2ca3a1c2dcd1
2 changes: 2 additions & 0 deletions playground/python/Python.AppHost/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

#pragma warning disable ASPIREHOSTINGPYTHON001 // Test for experimental feature

var builder = DistributedApplication.CreateBuilder(args);

builder.AddPythonApp("script-only", "../script_only", "main.py");
Expand Down
6 changes: 6 additions & 0 deletions src/Aspire.Hosting.Python/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.Diagnostics.CodeAnalysis;

[assembly: Experimental("ASPIREHOSTINGPYTHON001", UrlFormat = "https://aka.ms/dotnet/aspire/diagnostics#{0}")]
Copy link
Member

@joperezr joperezr Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, is the intention really to mark ALL APIs as experimental as opposed to just the new ones? Presumably we would want to keep the other ones not as experimental and instead just obsolete them?

Copy link
Member

@joperezr joperezr Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @eerhardt @DamianEdwards @sebastienros

Copy link
Member

@sebastienros sebastienros Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I am seeing in the PublicAPI files, all previous have been obsoleted, so everything is new. And everything is

  • one resource (PythonAppResource)
  • two extension methods (AddPythonApp)

Copy link
Member

@eerhardt eerhardt Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we just make ALL APIs in this library Experimental for 9.0. All the previous APIs are obsolete. And all the new APIs are experimental.

2 changes: 2 additions & 0 deletions tests/Aspire.Hosting.Python.Tests/AddPythonAppTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

#pragma warning disable ASPIREHOSTINGPYTHON001 // Test for experimental feature

using Xunit;
using Microsoft.Extensions.DependencyInjection;
using Aspire.Hosting.Utils;
Expand Down
2 changes: 2 additions & 0 deletions tests/Aspire.Hosting.Python.Tests/PythonPublicApiTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

#pragma warning disable ASPIREHOSTINGPYTHON001 // Test for experimental feature

using Aspire.Hosting.Utils;
using Xunit;

Expand Down