Configure OpenAI models in the app host #6577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
changed the title
sebastienros
commented
Oct 31, 2024
src/Components/Aspire.Azure.AI.OpenAI/DeploymentModelSettings.cs
Outdated
Show resolved
Hide resolved
sebastienros
commented
Oct 31, 2024
sebastienros
commented
Oct 31, 2024
src/Aspire.Hosting.Azure.CognitiveServices/AzureOpenAIConnectionResource.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Oct 31, 2024
src/Aspire.Hosting.Azure.CognitiveServices/PublicAPI.Shipped.txt
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.CognitiveServices/AzureOpenAIConnectionResource.cs
Outdated
Show resolved
Hide resolved
playground/OpenAIEndToEnd/OpenAIEndToEnd.WebStory/Components/Pages/Home.razor
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.CognitiveServices/IHasDeploymentsResource.cs
Outdated
Show resolved
Hide resolved
Member
|
Overall looks great. @eerhardt's point about the breaking change is probably the main thing to consider. Besides that it looks pretty close to being ready. |
16 tasks
SteveSandersonMS
force-pushed
the
stevesa/meai-integration
branch
from
4587b4b to
a29740a
Compare
sebastienros
force-pushed
the
sebros/hostmodels
branch
from
14cec51 to
16a16a3
Compare
…ebros/hostmodels # Conflicts: # playground/OpenAIEndToEnd/OpenAIEndToEnd.WebStory/Program.cs # src/Components/Aspire.Azure.AI.OpenAI/AspireAzureOpenAIClientBuilderChatClientExtensions.cs # src/Components/Aspire.Azure.AI.OpenAI/PublicAPI.Unshipped.txt
Member
Author
|
I updated the PR. @SteveSandersonMS is this something we could merge in your PR as it's impacting how configuration is passed to the clients. Other option is I wait for your PR to be done and then react to the changes. |
danmoseley
added
the
area-app-model
This was referenced Mar 5, 2025
eerhardt
added
area-integrations
Use it in the OpenAI playground.
Member
|
@sebastienros @captainsafia - I pushed some changes to this branch. I still need to update tests. But can you take a look at the current approach? |
eerhardt
reviewed
Mar 31, 2025
src/Aspire.Hosting.Azure.CognitiveServices/AzureOpenAIExtensions.cs
Outdated
Show resolved
Hide resolved
sebastienros
commented
Mar 31, 2025
dotnet-policy-service
bot
removed
the
needs-author-action
- Obsolete the existing APIs - Add unit tests - Switch the deployment name to default to the resource name
Change CreateDeployment to not take a ref and return the same thing.
captainsafia
approved these changes
Apr 1, 2025
Member
Author
|
Note that since I created the PR, I can't approve it ✅ |
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Apr 1, 2025
Configure OpenAI models in the app host as child resources. This allows for models/deployments to be WithReference'd directly and can easily be referenced from service apps. Contributes to dotnet#7907 * Add OpenAI child deployment resource. Use it in the OpenAI playground. * PR feedback - Obsolete the existing APIs - Add unit tests - Switch the deployment name to default to the resource name * PR feedback Change CreateDeployment to not take a ref and return the same thing. --------- Co-authored-by: Steve Sanderson <[email protected]> Co-authored-by: Eric Erhardt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building over @SteveSandersonMS PR to demonstrate the end-to-end experience when ai models/deployments are configured at the host level only.
Microsoft Reviewers: Open in CodeFlow