Skip to content

Conversation

@vnbaaij
Copy link
Contributor

@vnbaaij vnbaaij commented Nov 28, 2024

Update @JamesNK

4.11.x changes FluentDataGrid to use table/tr/td instead of web components. A lot of custom CSS and JavaScript needs to react to the new elements and attributes in the HTML.

I've been through the app a number of times and tested every page that has grids. It looks ok to me, but I'm sure there are some outstanding issues. I think the best way to find them is merge and have bugs reported about dashboard issues.


Update @vnbaaij
If you'd like to know more about the why behind the FluentDataGrid change, see microsoft/fluentui-blazor#2667

Description

Initial work needed to move to the Fluent UI Blazor 4.11.0 release (not out yet). This is still in draft.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@vnbaaij vnbaaij added this to the 9.1 milestone Nov 28, 2024
@JamesNK
Copy link
Member

JamesNK commented Dec 6, 2024

Stop and Play icons are no longer found:

image

They're both the filled variant. Changing variant to regular makes them resolve. Perhaps there is a bug finding any filled icons.

@JamesNK
Copy link
Member

JamesNK commented Dec 6, 2024

Data grid is getting a margin-bottom from table rule in reboot.css:

image

@JamesNK
Copy link
Member

JamesNK commented Dec 6, 2024

First column on structured logs and traces isn't positioned correctly:

image

@JamesNK
Copy link
Member

JamesNK commented Dec 6, 2024

Many issues on trace details:

image

@JamesNK
Copy link
Member

JamesNK commented Dec 6, 2024

Bad colors in details view:

image

@JamesNK
Copy link
Member

JamesNK commented Dec 6, 2024

As mentioned offline, there are many CSS rules that include fluent-data-grid-*: https://github.com/search?q=repo%3Adotnet%2Faspire%20fluent-data-grid&type=code

They're all broken and will cause bugs.

@vnbaaij
Copy link
Contributor Author

vnbaaij commented Dec 6, 2024

Stop and Play icons are no longer found:
They're both the filled variant. Changing variant to regular makes them resolve. Perhaps there is a bug finding any filled icons.

Yes, it is indeed a bug in selecting the right assembly to look in. Will be fixed for next build

@vnbaaij
Copy link
Contributor Author

vnbaaij commented Dec 6, 2024

Data grid is getting a margin-bottom from table rule in reboot.css:

I'm setting margin-bottom: 0px for fluent-data-grid class (rendered table automatically always ets that class name) in the component style

@vnbaaij
Copy link
Contributor Author

vnbaaij commented Dec 6, 2024

First column on structured logs and traces isn't positioned correctly:

In the pre v4.11 version, the button for the column was actually positioned against the left (no padding):
image

In the v4.11 version I've aligned the button as every other column (2nd image) by giving it an padding-inline-start:
image
image

We can solve by

  1. remove padding-inline-start - Column heading is displayed differently compared to other columns
  2. add padding-inline-start to the data entries as well - some horizontal screen estate is not used

What has preference?

@vnbaaij
Copy link
Contributor Author

vnbaaij commented Dec 6, 2024

Bad colors in details view:

Fixed by setting GenerateHeader default value to Default instead of Sticky (a sticky header gets this backgound color now to indicate it is sticky):

image
image

@vnbaaij
Copy link
Contributor Author

vnbaaij commented Dec 6, 2024

I've addressed most of the issues but would be good to go through a test together to see what needs to be fixed still. We do need to wait for a new version of the v4.11 packages to do so because we had to make some changes on our side as well.

@JamesNK
Copy link
Member

JamesNK commented Jan 13, 2025

@vnbaaij I've updated to 4.11.1 and fixed a lot more issues. I found one regression with empty rows (see microsoft/fluentui-blazor#3160)

@JamesNK JamesNK marked this pull request as ready for review January 15, 2025 04:21
@JamesNK JamesNK changed the title Initial work for using Fluent UI Blazor v4.11.0 Update Fluent UI Blazor to v4.11.3 Jan 15, 2025
@JamesNK JamesNK requested review from adamint, drewnoakes and eerhardt and removed request for eerhardt and radical January 15, 2025 04:23
@JamesNK JamesNK enabled auto-merge (squash) January 15, 2025 14:57
@JamesNK JamesNK disabled auto-merge January 15, 2025 22:36
@JamesNK JamesNK merged commit 2cf951a into main Jan 15, 2025
9 checks passed
@JamesNK JamesNK deleted the vnbaaij/fluentui-411 branch January 15, 2025 22:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants