[release/9.1] Create Login page EditContext before async work #7674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
approved these changes
Feb 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7671 to release/9.1
/cc @JamesNK
Customer Impact
A user reported this issue here - #7595. I think this is a very rare race condition between awaiting a task then creating the
EditContext, and parameters being set. If parameters are set before the context is created then it errors.Although this is the first reported instance of the error, it might have impacted more customers. The fix is simple: refresh the browser. Customers might not have taken the time to report the problem after it went away.
Testing
Unit test. Manual testing isn't really possible as it depends on a race condition.
Risk
Low
Regression?
No, not a 9.1 regression. This bug has been here since 8.0.