Skip to content

Conversation

@sebastienros
Copy link
Member

Description

This test is failing too often even on GH actions.

Tracking issue: #7522

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copilot AI review requested due to automatic review settings February 19, 2025 23:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@sebastienros
Copy link
Member Author

There might be a better way to disable these on GH (we have attributes for ADO).

/cc @adamint

@sebastienros
Copy link
Member Author

I got another failure on this PR from the same class, and now I see that the class has an [ActiveIssue] attribute to #4623, which is closed. Moved to #4921 which means these tests are never run on ADO either. (Updating the attribute to reflect the actual link)

@adamint adamint merged commit 6c22c58 into main Feb 20, 2025
70 checks passed
@adamint adamint deleted the sebros/skiptokentest branch February 20, 2025 01:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants