-
Notifications
You must be signed in to change notification settings - Fork 772
Docker Compose publishing #7963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Aspire.Hosting.Kubernetes/Generators/HelmOutputGenerator.cs
Outdated
Show resolved
Hide resolved
|
One of the things we will want to do is also look at modeling docker compose files, helm and k8s as resources much like how we do with the azure resources. (Cdk like objects for each) |
a467682 to
eff25f7
Compare
Thats probably a good call. It would - in turn, eventually allow compose and helm charts etc to be added to an AppHost as templates etc much like bicep supports. If we eventually went the AppHost route for addition / inclusion of those though, the provisioner would be pretty "full on" in terms of effort ^^ |
This is the plan 😄, but we should be incremental here so we can build up before we replicate the wrong pattern everywhere. |
|
Thoughts on https://cdk8s.io/ @prom3theu5 ? |
I am a fan. Also, c# support was recently added. I've also been following: Timoni quite closely But thats what we're going to eventually be able to replace with Aspire 😄 Are you thinking about including cdk8s projects in the AppHost? |
af51154 to
eb2355a
Compare
Only if they had C# support and it was extensible (and not going to die 😄). |
|
We could contribute to it as well. |
eb2355a to
80658e1
Compare
They do now - its not documented, but it was merged in 2 weeks ago ^^ |
538b970 to
ea5c963
Compare
|
These packages are in preview and we’ll keep it there until we get to a good approach. That said I’d like us to iterate on small commits, especially when we have something that we can try out. what do you think is the next step here @prom3theu5? We should pick one end to end to flesh out the “problems” and interactions between the cli and publisher (including stare management and prompting etc) |
176c91d to
8a06886
Compare
Yep! Compose is the easiest to work through, once thats in place - its relatively quick to work through the rest, as long as the pattern is satisfactory |
4458c31 to
e1d862e
Compare
Comment resolution - Remove no longer needed internals exposure - Keep publisher contexts internal - docs fix move ContainerReferenceParser to Shared, and link in Hosting, plus publishers
… + split Kubernetes to separate publishers (helm + kustomize)
…t project container image meta etc
…reating aspire network
…iter, too many blank lines No time to fix tonight though - and tomorrow will be a wash with commitments
3dd77fb to
beab5ab
Compare
|
Thanks for all your efforts @prom3theu5 |
|
Cheers Mitch 😃 |
Description
Starting to roll in the expansions to the publishers, to allow output in the various target asset types.
Ignore a lot of the processing within the Output generators for now, lots of changes to come - this is more for transparency / visibility atm.
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):