Remove role assignments on implicit storage account

[captainsafia]

Closes #8143.

Prior to this change, we still maintained a RoleAssignmentAnnotation for the implicit host storage resource even when WithHostStorage was called to set it explicitly. As a result of this, the AzureResourcePreparer would emit role assignments against this stale resource pointer. This declaration would be emitted into the manifest and result in a Bicep module for the stale implicit host storage still being created.

[Copilot]

Pull Request Overview

This pull request removes role assignments on an implicit storage account when an explicit host storage is provided, preventing the deployment of a stale implicit host storage resource in the manifest. It introduces additional tests to verify proper behavior with and without role assignments and updates the resource extension logic to remove legacy role assignment annotations.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
tests/Aspire.Hosting.Azure.Tests/AzureFunctionsTests.cs	Added tests to validate the WithHostStorage functionality and role assignment handling
src/Aspire.Hosting.Azure.Functions/AzureFunctionsProjectResourceExtensions.cs	Updated annotation removal logic and comments to remove stale role assignments for implicit storage

Comments suppressed due to low confidence (1)

src/Aspire.Hosting.Azure.Functions/AzureFunctionsProjectResourceExtensions.cs:67

• Using SingleOrDefault assumes that there will be at most one role assignment for the storage resource. If multiple annotations exist, this could throw an exception; consider using FirstOrDefault or adding validation to ensure uniqueness.

if (item.TryGetAnnotationsOfType<RoleAssignmentAnnotation>(out var roleAssignments) && roleAssignments.SingleOrDefault(assignment => assignment.Target == storage) is { } roleAssignmentAnnotation)

[eerhardt]

LGTM. Thanks!