Follow up on database role assignments #8212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respond to feedback from dotnet#8140
github-actions
bot
added
the
area-app-model
7 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR follows up on database role assignment feedback by introducing an interface abstraction for role assignment contexts and updating related components to use the new interface.
- Introduces IAddRoleAssignmentsContext to encapsulate role assignment details.
- Updates multiple resources (AzureProvisioningResource, AzureCosmosDBResource, AzureRedisCacheResource) to accept the interface instead of a concrete implementation.
- Renames variables and removes the deprecated AddRoleAssignmentsContext file to align with the new design.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Hosting.Azure/IAddRoleAssignmentsContext.cs | Added new interface for role assignments. |
| src/Aspire.Hosting.Azure.AppContainers/AddRoleAssignmentContext.cs | New sealed implementation of the role assignment context. |
| src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppsInfrastructure.cs | Renamed variable for clarity in resource iteration. |
| src/Aspire.Hosting.Azure/AzureProvisioningResource.cs | Updated method signature to use IAddRoleAssignmentsContext. |
| src/Aspire.Hosting.Azure.CosmosDB/AzureCosmosDBResource.cs | Updated method signature to use IAddRoleAssignmentsContext. |
| src/Aspire.Hosting.Azure.Redis/AzureRedisCacheResource.cs | Updated method signature to use IAddRoleAssignmentsContext. |
| src/Aspire.Hosting.Azure/AddRoleAssignmentsContext.cs | Removed obsolete concrete implementation file. |
davidfowl
approved these changes
Mar 20, 2025
captainsafia
approved these changes
Mar 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respond to feedback from #8140