Stabilize package versions#14003
Merged
Merged
Conversation
dougbu
commented
Sep 15, 2019
dougbu
commented
Contributor
- fix some versioning assumptions
- mark all installers as shipping
- available (though not discoverable) in public dotnetcli feed
…nsion packages have same version - Microsoft.AspNetCore.AzureAppServices.SiteExtension.3.0 ships - Microsoft.AspNetCore.AzureAppServices.SiteExtension.3.0.x?? do not ship
- VS.Redist.Common.AspNetCore.SharedFramework and ...TargetingPack packages are non-shipping - everything else ships nit: remove extra whitespace in .nuspec files for the packages
dougbu
added
the
area-infrastructure
Contributor
Author
Contributor
Author
|
May still have issues with shared Fx and installer tests. Also need to double-check installer versioning on all platforms. Will deal with both in the morning. |
- tests sometimes do not calculate version properties as product projects do - Microsoft.AspNetCore.App.Ref and ...Runtime packages may rev versions separately
…ests - `$(SharedFxVersion)` is not useful in test projects due to stable versioning
Contributor
Author
|
@mmitche and @aspnet/build I'll be away for a few hours. If this passes, please address any review comments and get this in. If it doesn't pass due to ProjectTemplates test failures, first add |
Contributor
Author
|
BTW the internal build created enough artifacts that I'm fairly confident everything is versioned correctly. |
Member
|
Adding continueOnError and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.