Skip to content

Update Async to server library #22575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
halter73 merged 42 commits into from
Sep 17, 2020
Merged

Update Async to server library #22575

halter73 merged 42 commits into from
Sep 17, 2020

Conversation

@hueifeng
Copy link
Contributor

@hueifeng hueifeng commented Jun 5, 2020

Modify some methods to be asynchronous.

@ghost ghost added the area-servers label Jun 5, 2020
@shirhatti shirhatti added this to the Next sprint planning milestone Jun 5, 2020
@shirhatti
Copy link
Contributor

shirhatti commented Jun 5, 2020

Solves #12334

@halter73
Copy link
Member

halter73 commented Jun 10, 2020

This at least partially solves #12334. There are more places we call Complete() outside of an async context which will likely be trickier to fix.

@hueifeng
Copy link
Contributor Author

hueifeng commented Jun 10, 2020

@halter73 I have modified some of the others. I am not sure whether we should keep both synchronous and asynchronous methods. I found that Abort is a synchronous method, and I am not sure whether to change it to asynchronous?

halter73
halter73 reviewed Jun 11, 2020
View reviewed changes
halter73
halter73 reviewed Jun 11, 2020
View reviewed changes
halter73
halter73 reviewed Jun 11, 2020
View reviewed changes
halter73
halter73 reviewed Jun 11, 2020
View reviewed changes
@halter73
Copy link
Member

halter73 commented Jun 11, 2020 •
edited
Loading

@hueifeng Thanks for working on this issues. I made my last comment about there being other calls to Complete() just so we don't prematurely close #12334. I wasn't asking you to address everything. I was going to merge your PR as it was.

It looks like you're on the right track though. If it gets too messy, I might just take the initial commit.

@halter73 I have modified some of the others. I am not sure whether we should keep both synchronous and asynchronous methods. I found that Abort is a synchronous method, and I am not sure whether to change it to asynchronous?

For internal interfaces and types, it's OK to get rid of the synchronous methods if they're not called.

halter73
halter73 reviewed Jun 11, 2020
View reviewed changes
halter73
halter73 reviewed Jun 11, 2020
View reviewed changes
halter73
halter73 reviewed Jun 11, 2020
View reviewed changes
@Tratcher Tratcher assigned halter73 and unassigned Tratcher Jul 1, 2020
@pranavkm
Copy link
Contributor

pranavkm commented Sep 10, 2020

Bad rebase?

hueifeng and others added 23 commits September 15, 2020 13:25
@hueifeng @halter73
Update Http3MessageBody.cs
64e6588
@hueifeng @halter73
Update Http2MessageBody.cs
6fa3bc2
@hueifeng @halter73
Update Http1ChunkedEncodingMessageBody.cs
08a083e
@hueifeng @halter73
Update Http1ContentLengthMessageBody.cs
dbe405f
@hueifeng @halter73
Update MessageBody.cs
92262e5
@hueifeng @halter73
Update Http1ChunkedEncodingMessageBody.cs
cc1f72e
@hueifeng @halter73
Update Http1UpgradeMessageBody.cs
68d2f05
@hueifeng @halter73
Update Http2MessageBody.cs
119cc93
@hueifeng @halter73
Update Http3MessageBody.cs
fd090e1
@hueifeng @halter73
Update ZeroContentLengthMessageBody.cs
0680051
@hueifeng @halter73
Update MessageBody.cs
580d344
@hueifeng @halter73
Update Http3Stream.cs
96a3cbb
@hueifeng @halter73
Update ZeroContentLengthMessageBody.cs
37b08e0
@hueifeng @halter73
Update Http1UpgradeMessageBody.cs
b493c0e
@hueifeng @halter73
Update Http2Connection.cs
715a845
@hueifeng @halter73
Update src/Servers/Kestrel/Core/src/Internal/Http/Http1ChunkedEncodin…
eb61fc1 
…gMessageBody.cs

Co-authored-by: Stephen Halter <[email protected]>
@hueifeng @halter73
Update src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs
934c054 
Co-authored-by: Stephen Halter <[email protected]>
@hueifeng @halter73
Update src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs
6806e32 
Co-authored-by: Stephen Halter <[email protected]>
@hueifeng @halter73
Update Http1ChunkedEncodingMessageBody.cs
30cb66c
@hueifeng @halter73
Update Http3FrameWriter.cs
d80891b
@halter73
Cleanup
eef9dd9
@halter73
Add HttpResponsePipeWriter.CompleteAsync()
43b7f95
@halter73
More cleanup
25a0c12
@halter73 halter73 merged commit 1cb3f23 into dotnet:master Sep 17, 2020
@halter73 halter73 mentioned this pull request Sep 21, 2020
Closed
@runfoapp runfoapp bot mentioned this pull request Sep 29, 2020
Closed
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesNK JamesNK JamesNK left review comments

@halter73 halter73 halter73 approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

@halter73 halter73

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

6.0-preview1

Development

Successfully merging this pull request may close these issues.

8 participants

@hueifeng @shirhatti @halter73 @pranavkm @JamesNK @Pilchie @Tratcher @amcasey