Update SDK #25081

BrennanConroy · 2020-08-20T17:50:20Z

Hopefully this will have some changes for the ARM issue we're seeing in #24841

pranavkm · 2020-08-20T18:01:44Z

💥

dougbu

Looks like the latest SDK still has problems. Or, at least it can't work on the agents we're using.

/cc @dsplaisted @marcpopMSFT @sfoslund @clairernovotny @nkolev92

dougbu · 2020-08-20T18:03:53Z

Put another way, dotnet/sdk#12897 didn't help us.

BrennanConroy · 2020-08-20T18:05:00Z

Put another way, dotnet/sdk#12897 didn't help us.

Are we sure that change is in this version we're grabbing?

dougbu · 2020-08-20T18:08:36Z

Not certain though the change was merged 4 days ago and the SDK used here is from this morning.

marcpopMSFT · 2020-08-20T18:36:58Z

What version of VS is being used here? The problem may be that you need 16.8.p2 to work with this sdk. @nkolev92 , does that sound right? What is their path forward until that's available?

BrennanConroy · 2020-08-20T18:47:30Z

What version of VS is being used here?

Shouldn't matter for the Unix machines that are failing with the same error.

dougbu · 2020-08-20T18:50:35Z

What version of VS is being used here?

For example, from the macOS build:

/Users/runner/work/1/s/.dotnet/sdk/5.0.100-rc.1.20420.10/NuGet.targets(128,5): error : Invalid restore input. Invalid target framework 'unsupported'. Input files: /Users/runner/work/1/s/.packages/microsoft.dotnet.arcade.sdk/5.0.0-beta.20417.6/tools/Tools.proj. [/Users/runner/work/1/s/.packages/microsoft.dotnet.arcade.sdk/5.0.0-beta.20417.6/tools/Tools.proj]

It appears the .NET SDK contains a breaking change that required the dotnet/arcade@f8d1331#diff-49032945af4968a76e1ae76f37234d19 workaround. We need a new Arcade SDK to get things working with a newer .NET SDK.

@BrennanConroy I suggest triggering our Arcade subscription because they just promoted a new build. According to dotnet/arcade@83fda4b...56a95cc, the build includes the above workaround.

dougbu

Withdrawing my changes request in hopes this works.

nit: I meant trigger-subscriptions not update-dependencies but am fine w/ keeping everything in this PR.

BrennanConroy · 2020-08-20T19:16:31Z

Looks like some extra checks have been added. I'll fix the taskcontinuationoptions, not sure about netcoreapp3.0 yet.

dougbu · 2020-08-20T19:16:54Z

Oops, new errors about targeting netcoreapp3.0 and a breaking change somewhere. But, looks better than the last run❕

BrennanConroy · 2020-08-20T21:00:17Z

This is going to be a fun PR 😰

BrennanConroy · 2020-08-21T05:13:52Z

src/JSInterop/Microsoft.JSInterop/src/JSRuntime.cs

        {
            var taskId = Interlocked.Increment(ref _nextPendingTaskId);
-            var tcs = new TaskCompletionSource<TValue>(TaskContinuationOptions.RunContinuationsAsynchronously);
+            var tcs = new TaskCompletionSource<TValue>(TaskCreationOptions.RunContinuationsAsynchronously);


Looks like a bunch of tests relied on this being inline instead of async

Tests like Microsoft.JSInterop.Infrastructure.DotNetDispatcherTest.EndInvokeJS_WithNullValue are failing w/ expected true, got false. @pranavkm @captainsafia should we remove the async continuation, or fix up the tests?

Remove https://github.com/dotnet/aspnetcore/pull/25081/files#diff-799ff3281d6420f4ff7469e3402a2d25R29 whenever this question gets answered. #25111 fixed the netcoreapp3.0 issue.

ping @pranavkm @captainsafia can we get this resolved today?

wtgodbe · 2020-08-21T18:40:06Z

IntrospectRazorTasksDllPath_DesktopMsBuild fails with:

error MSB4186: Invalid static method invocation syntax: "[MSBuild]::GetTargetFrameworkIdentifier('$(TargetFramework)')". Method '[MSBuild]::GetTargetFrameworkIdentifier' not found. Static method invocation should be of the form: $([FullTypeName]::Method()), e.g. $([System.IO.Path]::Combine(a, b)). Check that all parameters are defined, are of the correct type, and are specified in the right order.

failure is here

https://github.com/dotnet/sdk/blob/86ba2c3bdc5ab3eb71dfeebda5c51487ecce1328/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.TargetFrameworkInference.targets#L54

wtgodbe · 2020-08-21T18:46:20Z

@sfoslund @wli3 looks like there was some churn there recently, could it be related to dotnet/sdk#12897?

sfoslund · 2020-08-21T18:51:36Z

@wtgodbe that failure likely means the version of MSBuild that's being used isn't recent enough. Is it possible you might need to update the version of xcopy-msbuild that's being used here? It's 16.5.0-alpha right now which definitely doesn't have the necessary intrinsic functions.

wtgodbe · 2020-08-21T18:52:47Z

Is it possible you might need to update the version of xcopy-msbuild that's being used here? It's 16.5.0-alpha right now which definitely doesn't have the necessary intrinsic functions.

Seems very possible - how can I know what a good version to use would be?

@dougbu is there a strong reason we're on that particular version of xcopy-msbuild?

sfoslund · 2020-08-21T18:56:41Z

We're using 16.8.0-preview2.1, which was generated from last Friday's dogfood, so it has all the necessary nuget and MSBuild changes.

wtgodbe · 2020-08-21T18:58:38Z

I will give that a try, thanks!

dougbu · 2020-08-21T19:35:13Z

Is it possible you might need to update the version of xcopy-msbuild that's being used here?

We're not using the xcopy version of msbuild at all. That's there only to provide a fallback for users that don't have VS installed at all and are fine with excluding the native builds.

In fact, that version won't work at all for our builds due to our need for Microsoft.VisualStudio.Component.VC.ATL and Microsoft.VisualStudio.Component.VC.Tools.x86.x64. I tried extending the xcopy version's extension path and just ended up in a world of assembly load failures because VS on the agents was 16.5 or 16.6 at that point.

@wtgodbe your change isn't going to change anything because the build will successfully find the 16.5 VS installation and use msbuild from that.

Further, this whole conversation is about the desktop msbuild and we use dotnet msbuild except when building native projects and Wix projects. If that test invokes desktop msbuild, I recommend disabling it 'til the agents are updated.

dougbu · 2020-08-23T06:16:41Z

This PR still contains an Arcade SDK update. Should it❔
Should this PR target release/5.0 at this point in the release❔

BrennanConroy · 2020-08-23T21:20:37Z

1. This PR still contains an Arcade SDK update. Should it❔

That's just because git isn't showing the PR rebased on release/5.0 correctly since the arcade update went in from a different PR.

2\. Should this PR target release/5.0 at this point in the release❔

Why not? Unless we're planning on indefinitely targeting an old SDK in 5.0, then we'll need to update it at some point and the earlier the better.

dougbu · 2020-08-24T17:08:16Z

Why not? Unless we're planning on indefinitely targeting an old SDK in 5.0, then we'll need to update it at some point and the earlier the better.

Because we're in ask mode, the change is unreasonably painful, and moving to something other than (say) the stable / released RC1 SDK after that's out seems nice-to-have but not required.

wtgodbe · 2020-08-24T17:09:45Z

We could go for the preview8 SDK once it releases

wtgodbe · 2020-08-24T20:08:59Z

We're going to punt this work until we get the RC1 SDK: #25214

Update SDK

135be53

BrennanConroy added the tell-mode Indicates a PR which is being merged during tell-mode label Aug 20, 2020

BrennanConroy added this to the 5.0.0-rc1 milestone Aug 20, 2020

BrennanConroy requested review from a team and pranavkm August 20, 2020 17:50

ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 20, 2020

dougbu suggested changes Aug 20, 2020

View reviewed changes

Update Arcade

4fb6bb9

BrennanConroy changed the title ~~Update SDK~~ Update SDK and Arcade Aug 20, 2020

dougbu approved these changes Aug 20, 2020

View reviewed changes

errors

7255155

BrennanConroy requested review from a team and SteveSandersonMS as code owners August 20, 2020 20:30

Update JSRuntime.cs

9bc3fdc

more errors

5a8a016

BrennanConroy requested review from Tratcher, halter73, javiercn and jkotalik as code owners August 20, 2020 21:46

BrennanConroy requested a review from a team August 20, 2020 21:46

BrennanConroy added 2 commits August 20, 2020 16:12

razor :/

5c9b6c9

copy paste error

b1e7b47

BrennanConroy commented Aug 21, 2020

View reviewed changes

Update xcopy-msbuild

ba4169c

Quarantine test

7d39c24

BrennanConroy changed the title ~~Update SDK and Arcade~~ Update SDK Aug 22, 2020

wtgodbe mentioned this pull request Aug 24, 2020

Update to RC1 SDK #25214

Closed

wtgodbe closed this Aug 24, 2020

dougbu mentioned this pull request Aug 25, 2020

dotnet watch tests timing out #24841

Closed

BrennanConroy mentioned this pull request Aug 31, 2020

Update to latest SDK #25421

Merged

mkArtakMSFT mentioned this pull request Sep 2, 2020

WebAssembly benchmark app includes PDBs in publish output #25533

Closed

BrennanConroy deleted the brecon/sdkupdate branch December 28, 2020 19:08

Update SDK #25081

Update SDK #25081

Uh oh!

Conversation

BrennanConroy commented Aug 20, 2020

Uh oh!

pranavkm commented Aug 20, 2020

Uh oh!

dougbu left a comment

Choose a reason for hiding this comment

Uh oh!

dougbu commented Aug 20, 2020

Uh oh!

BrennanConroy commented Aug 20, 2020

Uh oh!

dougbu commented Aug 20, 2020

Uh oh!

marcpopMSFT commented Aug 20, 2020

Uh oh!

BrennanConroy commented Aug 20, 2020

Uh oh!

dougbu commented Aug 20, 2020

Uh oh!

dougbu left a comment

Choose a reason for hiding this comment

Uh oh!

BrennanConroy commented Aug 20, 2020

Uh oh!

dougbu commented Aug 20, 2020

Uh oh!

BrennanConroy commented Aug 20, 2020

Uh oh!

BrennanConroy Aug 21, 2020

Choose a reason for hiding this comment

Uh oh!

wtgodbe Aug 21, 2020

Choose a reason for hiding this comment

Uh oh!

BrennanConroy Aug 22, 2020

Choose a reason for hiding this comment

Uh oh!

wtgodbe Aug 24, 2020

Choose a reason for hiding this comment

Uh oh!

wtgodbe commented Aug 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wtgodbe commented Aug 21, 2020

Uh oh!

sfoslund commented Aug 21, 2020

Uh oh!

wtgodbe commented Aug 21, 2020

Uh oh!

sfoslund commented Aug 21, 2020

Uh oh!

wtgodbe commented Aug 21, 2020

Uh oh!

dougbu commented Aug 21, 2020

Uh oh!

dougbu commented Aug 23, 2020

Uh oh!

BrennanConroy commented Aug 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dougbu commented Aug 24, 2020

Uh oh!

wtgodbe commented Aug 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wtgodbe commented Aug 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

wtgodbe commented Aug 21, 2020 •

edited

Loading

BrennanConroy commented Aug 23, 2020 •

edited

Loading

wtgodbe commented Aug 24, 2020 •

edited

Loading

wtgodbe commented Aug 24, 2020 •

edited

Loading