Skip to content

Conversation

@javiercn
Copy link
Member

@javiercn javiercn commented Sep 8, 2020

Description

Updates the error page in the Blazor templates to match the rest of the ASP.NET Core templates.

Customer Impact

The UI is not styled properly, and some error details might not be accessible.

Regression?

Yes

Risk

Very low, the change is in the template, so customers can adjust it if needed and we validated the change manually.

Fixes

#22712 (comment)

@javiercn javiercn requested a review from a team as a code owner September 8, 2020 19:16
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Sep 8, 2020
@javiercn javiercn force-pushed the javiercn/error-cshtml branch from 62e96c4 to 20d5426 Compare September 8, 2020 19:21
@javiercn
Copy link
Member Author

I validated the changes manually which was the only thing left.

@Pilchie this is ready to go once the CI is green

@javiercn javiercn added the ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. label Sep 10, 2020
@Pilchie Pilchie added the Servicing-approved Shiproom has approved the issue label Sep 10, 2020
@Pilchie
Copy link
Member

Pilchie commented Sep 10, 2020

Approved for .NET 5.0 RC2.

@Pilchie Pilchie merged commit 31fcc8b into release/5.0-rc2 Sep 10, 2020
@Pilchie Pilchie deleted the javiercn/error-cshtml branch September 10, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants