Point to the correct directory for SDK test assets #25734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ends up building SDK's test assets as part of a regular build which ends up failing in a clean build.
ghost
added
the
area-infrastructure
pranavkm
requested review from
a team,
BrennanConroy,
SteveSandersonMS,
Tratcher,
dougbu,
halter73,
javiercn and
jkotalik
as code owners
pranavkm
removed request for
a team,
BrennanConroy,
SteveSandersonMS,
dougbu,
halter73,
javiercn and
jkotalik
wtgodbe
approved these changes
Sep 9, 2020
dougbu
approved these changes
Sep 9, 2020
Contributor
|
Just curious: Did a src\Components\WebAssembly\Build folder exist at some point❔ |
Contributor
Author
It did. That was the folder for our package containing MSBuild tasks and targets until we rolled in to the SDK. |
mkArtakMSFT
added
the
tell-mode
Contributor
|
@Pilchie FYI this is being merged as it's test-related change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ends up building SDK's test assets as part of a regular build which ends up failing in a clean build.