Skip to content

DataProtection: Move away from soon to be obsolete APIs #32511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoK merged 1 commit into from
May 10, 2021
Merged

DataProtection: Move away from soon to be obsolete APIs #32511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions ...ection/DataProtection/src/AuthenticatedEncryption/ManagedAuthenticatedEncryptorFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,7 @@ private Func<SymmetricAlgorithm> GetSymmetricBlockCipherAlgorithmFactory(Managed

if (configuration.EncryptionAlgorithmType == typeof(Aes))
{
Func<Aes>? factory = null;
if (OSVersionUtil.IsWindows())
{
// If we're on desktop CLR and running on Windows, use the FIPS-compliant implementation.
factory = () => new AesCryptoServiceProvider();
}

return factory ?? Aes.Create;
return Aes.Create;
Copy link
Contributor

@pranavkm pranavkm May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the FIPS compliance statement no longer valid?

Copy link
Member Author

@HaoK HaoK May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AesCryptoServiceProvider is being obsoleted, not sure if the base API is FIPS compliant?

Copy link
Contributor

@pranavkm pranavkm May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, but that's in netcore, no? Aes in net461 is probably not FIPs compliant. Do we need to cross-compile this?

Copy link
Member Author

@HaoK HaoK May 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrabYourPitchforks is this safe to just always use Aes.Create now?

}
else
{
Expand Down
2 changes: 1 addition & 1 deletion src/DataProtection/DataProtection/test/XmlEncryption/CertificateXmlEncryptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class CertificateXmlEncryptorTests
public void Encrypt_Decrypt_RoundTrips()
{
// Arrange
var symmetricAlgorithm = new TripleDESCryptoServiceProvider();
var symmetricAlgorithm = TripleDES.Create();
symmetricAlgorithm.GenerateKey();

var mockInternalEncryptor = new Mock<IInternalCertificateXmlEncryptor>();
Expand Down