Skip to content

Kestrel response header encoding #33776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tratcher merged 26 commits into from
Jul 6, 2021
Merged

Kestrel response header encoding #33776

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
941c90c
TEMP: Add response header encoding callback
Tratcher Jun 3, 2021
ca17faf
Add trailers test
Tratcher Jun 3, 2021
134458d
HTTP/2 response headers test
Tratcher Jun 18, 2021
8534569
HTTP/1 custom header encoding
Tratcher Jun 19, 2021
a0ab85f
Custom encoding for known headers
Tratcher Jun 21, 2021
1b2b675
Validate custom encodings
Tratcher Jun 21, 2021
d31b314
Cleanup
Tratcher Jun 21, 2021
ed83a04
Http/2 hpack encoding
Tratcher Jun 22, 2021
a6834a6
More validation, HTTP/2 trailers tests
Tratcher Jun 22, 2021
7080853
Http/3
Tratcher Jun 22, 2021
d1a8fd6
Add Http3HeadersEnumerator
Tratcher Jun 23, 2021
9ae09d4
Efficient encoding
Tratcher Jun 23, 2021
0f96bbd
Reduce validation on add, error handling
Tratcher Jun 23, 2021
759ef3a
Http/3 error handling and tests
Tratcher Jun 24, 2021
2d47ee4
Cleanup TODOs
Tratcher Jun 24, 2021
8b01902
Fixup request encoding
Tratcher Jun 24, 2021
30499c5
Clean up generated spacing
Tratcher Jun 25, 2021
d2797d5
Formatting
Tratcher Jun 25, 2021
c1f9efd
Count encoded length
Tratcher Jun 25, 2021
0def2d1
hpack benchmark improvements
Tratcher Jun 25, 2021
d89a9b0
PR feedback
Tratcher Jun 28, 2021
465249d
Revert stackalloc change
Tratcher Jun 30, 2021
056d853
H/Qpack encoding errors
Tratcher Jun 30, 2021
b518b31
Fix test issues
Tratcher Jun 30, 2021
94d51ed
Test fix
Tratcher Jul 1, 2021
0c03bf2
Log symmetry
Tratcher Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Formatting
  • Loading branch information
@Tratcher
Tratcher committed Jun 30, 2021
commit d2797d5e0b258dedd79f84e8fe9d654f665931fb
46 changes: 0 additions & 46 deletions src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.Generated.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1568,7 +1568,6 @@ StringValues IHeaderDictionary.AcceptRanges
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.AcceptRanges, value);
}
}
Expand All @@ -1586,7 +1585,6 @@ StringValues IHeaderDictionary.AccessControlAllowCredentials
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.AccessControlAllowCredentials, value);
}
}
Expand All @@ -1604,7 +1602,6 @@ StringValues IHeaderDictionary.AccessControlAllowHeaders
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.AccessControlAllowHeaders, value);
}
}
Expand All @@ -1622,7 +1619,6 @@ StringValues IHeaderDictionary.AccessControlAllowMethods
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.AccessControlAllowMethods, value);
}
}
Expand All @@ -1640,7 +1636,6 @@ StringValues IHeaderDictionary.AccessControlAllowOrigin
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.AccessControlAllowOrigin, value);
}
}
Expand All @@ -1658,7 +1653,6 @@ StringValues IHeaderDictionary.AccessControlExposeHeaders
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.AccessControlExposeHeaders, value);
}
}
Expand All @@ -1676,7 +1670,6 @@ StringValues IHeaderDictionary.AccessControlMaxAge
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.AccessControlMaxAge, value);
}
}
Expand All @@ -1694,7 +1687,6 @@ StringValues IHeaderDictionary.Age
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.Age, value);
}
}
Expand All @@ -1712,7 +1704,6 @@ StringValues IHeaderDictionary.Allow
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.Allow, value);
}
}
Expand All @@ -1730,7 +1721,6 @@ StringValues IHeaderDictionary.AltSvc
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.AltSvc, value);
}
}
Expand All @@ -1748,7 +1738,6 @@ StringValues IHeaderDictionary.ContentDisposition
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.ContentDisposition, value);
}
}
Expand All @@ -1766,7 +1755,6 @@ StringValues IHeaderDictionary.ContentEncoding
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.ContentEncoding, value);
}
}
Expand All @@ -1784,7 +1772,6 @@ StringValues IHeaderDictionary.ContentLanguage
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.ContentLanguage, value);
}
}
Expand All @@ -1802,7 +1789,6 @@ StringValues IHeaderDictionary.ContentLocation
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.ContentLocation, value);
}
}
Expand All @@ -1820,7 +1806,6 @@ StringValues IHeaderDictionary.ContentMD5
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.ContentMD5, value);
}
}
Expand All @@ -1838,7 +1823,6 @@ StringValues IHeaderDictionary.ContentRange
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.ContentRange, value);
}
}
Expand All @@ -1856,7 +1840,6 @@ StringValues IHeaderDictionary.ContentSecurityPolicy
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.ContentSecurityPolicy, value);
}
}
Expand All @@ -1874,7 +1857,6 @@ StringValues IHeaderDictionary.ContentSecurityPolicyReportOnly
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.ContentSecurityPolicyReportOnly, value);
}
}
Expand All @@ -1892,7 +1874,6 @@ StringValues IHeaderDictionary.ETag
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.ETag, value);
}
}
Expand All @@ -1910,7 +1891,6 @@ StringValues IHeaderDictionary.Expires
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.Expires, value);
}
}
Expand All @@ -1928,7 +1908,6 @@ StringValues IHeaderDictionary.GrpcMessage
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.GrpcMessage, value);
}
}
Expand All @@ -1946,7 +1925,6 @@ StringValues IHeaderDictionary.GrpcStatus
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.GrpcStatus, value);
}
}
Expand All @@ -1964,7 +1942,6 @@ StringValues IHeaderDictionary.LastModified
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.LastModified, value);
}
}
Expand All @@ -1982,7 +1959,6 @@ StringValues IHeaderDictionary.Link
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.Link, value);
}
}
Expand All @@ -2000,7 +1976,6 @@ StringValues IHeaderDictionary.Location
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.Location, value);
}
}
Expand All @@ -2018,7 +1993,6 @@ StringValues IHeaderDictionary.ProxyAuthenticate
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.ProxyAuthenticate, value);
}
}
Expand All @@ -2036,7 +2010,6 @@ StringValues IHeaderDictionary.ProxyConnection
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.ProxyConnection, value);
}
}
Expand All @@ -2054,7 +2027,6 @@ StringValues IHeaderDictionary.RetryAfter
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.RetryAfter, value);
}
}
Expand All @@ -2072,7 +2044,6 @@ StringValues IHeaderDictionary.SecWebSocketAccept
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.SecWebSocketAccept, value);
}
}
Expand All @@ -2090,7 +2061,6 @@ StringValues IHeaderDictionary.SecWebSocketKey
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.SecWebSocketKey, value);
}
}
Expand All @@ -2108,7 +2078,6 @@ StringValues IHeaderDictionary.SecWebSocketProtocol
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.SecWebSocketProtocol, value);
}
}
Expand All @@ -2126,7 +2095,6 @@ StringValues IHeaderDictionary.SecWebSocketVersion
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.SecWebSocketVersion, value);
}
}
Expand All @@ -2144,7 +2112,6 @@ StringValues IHeaderDictionary.SecWebSocketExtensions
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.SecWebSocketExtensions, value);
}
}
Expand All @@ -2162,7 +2129,6 @@ StringValues IHeaderDictionary.Server
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.Server, value);
}
}
Expand All @@ -2180,7 +2146,6 @@ StringValues IHeaderDictionary.SetCookie
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.SetCookie, value);
}
}
Expand All @@ -2198,7 +2163,6 @@ StringValues IHeaderDictionary.StrictTransportSecurity
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.StrictTransportSecurity, value);
}
}
Expand All @@ -2216,7 +2180,6 @@ StringValues IHeaderDictionary.Trailer
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.Trailer, value);
}
}
Expand All @@ -2234,7 +2197,6 @@ StringValues IHeaderDictionary.Vary
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.Vary, value);
}
}
Expand All @@ -2252,7 +2214,6 @@ StringValues IHeaderDictionary.WebSocketSubProtocols
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.WebSocketSubProtocols, value);
}
}
Expand All @@ -2270,7 +2231,6 @@ StringValues IHeaderDictionary.WWWAuthenticate
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.WWWAuthenticate, value);
}
}
Expand All @@ -2288,7 +2248,6 @@ StringValues IHeaderDictionary.XContentTypeOptions
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.XContentTypeOptions, value);
}
}
Expand All @@ -2306,7 +2265,6 @@ StringValues IHeaderDictionary.XFrameOptions
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.XFrameOptions, value);
}
}
Expand All @@ -2324,7 +2282,6 @@ StringValues IHeaderDictionary.XPoweredBy
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.XPoweredBy, value);
}
}
Expand All @@ -2342,7 +2299,6 @@ StringValues IHeaderDictionary.XRequestedWith
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.XRequestedWith, value);
}
}
Expand All @@ -2360,7 +2316,6 @@ StringValues IHeaderDictionary.XUACompatible
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.XUACompatible, value);
}
}
Expand All @@ -2378,7 +2333,6 @@ StringValues IHeaderDictionary.XXSSProtection
set
{
if (_isReadOnly) { ThrowHeadersReadOnlyException(); }

SetValueUnknown(HeaderNames.XXSSProtection, value);
}
}
Expand Down
5 changes: 2 additions & 3 deletions src/Servers/Kestrel/shared/KnownHeaders.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,9 +890,8 @@ StringValues IHeaderDictionary.{header}
}}
set
{{
if (_isReadOnly) {{ ThrowHeadersReadOnlyException(); }}
{(loop.ClassName != "HttpRequestHeaders" ?
$@"ValidateHeaderValueCharacters(HeaderNames.{header}, value, EncodingSelector);" : "")}
if (_isReadOnly) {{ ThrowHeadersReadOnlyException(); }}{(loop.ClassName != "HttpRequestHeaders" ? $@"
ValidateHeaderValueCharacters(HeaderNames.{header}, value, EncodingSelector);" : "")}
SetValueUnknown(HeaderNames.{header}, value);
}}
}}")}
Expand Down