Skip to content

Configure ALPN for callback scenarios #34242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tratcher merged 2 commits into from
Jul 18, 2021
Merged

Configure ALPN for callback scenarios #34242

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38ee6ea
Configure APLN for callback scenarios #31303
Tratcher Jul 9, 2021
5471a48
Update HttpsConnectionMiddlewareTests.cs
Tratcher Jul 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update HttpsConnectionMiddlewareTests.cs
  • Loading branch information
@Tratcher
Tratcher authored Jul 10, 2021
commit 5471a48acec39e58254815918b38cb5073728f39
33 changes: 33 additions & 0 deletions src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsConnectionMiddlewareTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,6 +852,39 @@ await stream.AuthenticateAsClientAsync(new SslClientAuthenticationOptions()
Assert.Equal(SslApplicationProtocol.Http2, stream.NegotiatedApplicationProtocol);
}

[ConditionalFact]
[OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "ALPN not supported")]
public async Task TlsHandshakeCallbackOptionsOverload_EmptyAlpnList_DisablesAlpn()
{
static void ConfigureListenOptions(ListenOptions listenOptions)
{
listenOptions.UseHttps(new TlsHandshakeCallbackOptions()
{
OnConnection = context =>
{
return ValueTask.FromResult(new SslServerAuthenticationOptions()
{
ServerCertificate = _x509Certificate2,
ApplicationProtocols = new(),
});
}
});
}

await using var server = new TestServer(context => Task.CompletedTask,
new TestServiceContext(LoggerFactory), ConfigureListenOptions);

using var connection = server.CreateConnection();
var stream = OpenSslStream(connection.Stream);
await stream.AuthenticateAsClientAsync(new SslClientAuthenticationOptions()
{
// Use a random host name to avoid the TLS session resumption cache.
TargetHost = Guid.NewGuid().ToString(),
ApplicationProtocols = new() { SslApplicationProtocol.Http2, SslApplicationProtocol.Http11, },
});
Assert.Equal(default, stream.NegotiatedApplicationProtocol);
}

[ConditionalFact]
[OSSkipCondition(OperatingSystems.MacOSX | OperatingSystems.Linux, SkipReason = "Not supported yet.")]
public async Task CanRenegotiateForClientCertificateOnPostIfDrained()
Expand Down