-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Update sdk to 7.0.100-alpha.1.21470.6 #36781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please update these 2 projects to use
|
wtgodbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can update RepoTasks & RunTests now as well
|
@wtgodbe Updated (4e3bd0e). Should the following also be updated to reference net7.0? aspnetcore/eng/tools/GenerateFiles/Directory.Build.targets.in Lines 11 to 27 in 7b09459
It also looks like https://github.com/dotnet/spa-templates needs TFM updates. |
No, that's copying the previous tfm's frameworkReference but with the current TFM, in case there isn't already a FrameworkReference for the current TFM (which there wasn't before this PR). Spa-Templates should be a simple find/replace, I can take care of it if you want |
|
/azp run |
|
🤞 |
|
Azure Pipelines successfully started running 3 pipeline(s). |
- SDK hasn't been updated _enough_
|
@marcpopMSFT @dsplaisted @wli I'm only seeing (Side note: Why is the SDK still carting around |
|
@wtgodbe please approve to remove your block on this PR. Can't update |
|
Must stay at |
We want people to use the latest SDK, so it will still support building projects targeting .NET Core 1.0 (which didn't use |
|
Hi @dsplaisted. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
No description provided.