Skip to content

Conversation

@halter73
Copy link
Member

No description provided.

@halter73 halter73 added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 21, 2021
@halter73 halter73 requested a review from a team as a code owner September 21, 2021 04:57
@dougbu
Copy link
Contributor

dougbu commented Sep 21, 2021

@wtgodbe is this SDK new enough to undo any of the workarounds added in #36328❔ If yes, I suggest adding comments to remind us what we'll likely need to change the next time we change TFMs before supporting SDK exists. Also good fodder for your major / minor change doc.

@wtgodbe
Copy link
Member

wtgodbe commented Sep 21, 2021

Please update these 2 projects to use DefaultNetCoreTargetFramework

<TargetFramework>net6.0</TargetFramework>

<TargetFrameworks>net6.0</TargetFrameworks>

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can update RepoTasks & RunTests now as well

@halter73
Copy link
Member Author

@wtgodbe Updated (4e3bd0e). Should the following also be updated to reference net7.0?

<ItemGroup>
<KnownAppHostPack
Include="@(KnownAppHostPack->WithMetadataValue('TargetFramework', 'net6.0'))"
TargetFramework="${DefaultNetCoreTargetFramework}"
Condition="@(KnownAppHostPack->Count()) != '0' AND
!(@(KnownAppHostPack->AnyHaveMetadataValue('TargetFramework', '${DefaultNetCoreTargetFramework}')))" />
<KnownRuntimePack
Include="@(KnownRuntimePack->WithMetadataValue('TargetFramework', 'net6.0'))"
TargetFramework="${DefaultNetCoreTargetFramework}"
Condition="@(KnownRuntimePack->Count()) != '0' AND
!(@(KnownRuntimePack->AnyHaveMetadataValue('TargetFramework', '${DefaultNetCoreTargetFramework}')))" />
<KnownFrameworkReference
Include="@(KnownFrameworkReference->WithMetadataValue('TargetFramework', 'net6.0'))"
TargetFramework="${DefaultNetCoreTargetFramework}"
Condition="@(KnownFrameworkReference->Count()) != '0' AND
!(@(KnownFrameworkReference->AnyHaveMetadataValue('TargetFramework', '${DefaultNetCoreTargetFramework}')))" />
</ItemGroup>

It also looks like https://github.com/dotnet/spa-templates needs TFM updates.

@wtgodbe
Copy link
Member

wtgodbe commented Sep 23, 2021

Should the following also be updated to reference net7.0?

No, that's copying the previous tfm's frameworkReference but with the current TFM, in case there isn't already a FrameworkReference for the current TFM (which there wasn't before this PR). Spa-Templates should be a simple find/replace, I can take care of it if you want

@wtgodbe
Copy link
Member

wtgodbe commented Sep 23, 2021

dotnet/spa-templates#21

@dougbu
Copy link
Contributor

dougbu commented Sep 27, 2021

@halter73 @wtgodbe should we run the pipeline again i.e. should the spa-templates submodule update be enough to get this working❔

@dougbu
Copy link
Contributor

dougbu commented Sep 27, 2021

/azp run

@dougbu
Copy link
Contributor

dougbu commented Sep 27, 2021

🤞

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

- SDK hasn't been updated _enough_
@dougbu
Copy link
Contributor

dougbu commented Sep 27, 2021

@marcpopMSFT @dsplaisted @wli I'm only seeing @(KnownFrameworkReference) items with %(TargetFramework) metadata for netcoreapp3.0, netcoreapp3.1, net5.0, and net6.0. Why isn't net7.0 in there yet❔

(Side note: Why is the SDK still carting around netcoreapp3.0❔)

@dougbu
Copy link
Contributor

dougbu commented Sep 27, 2021

@wtgodbe please approve to remove your block on this PR. Can't update RepoTasks yet.

@dougbu
Copy link
Contributor

dougbu commented Sep 27, 2021

Must stay at net6.0 in both RepoTasks and RunTests for now. The SDK's understanding of net7.0 isn't complete enough yet.

@dougbu dougbu enabled auto-merge (squash) September 27, 2021 19:41
@dougbu dougbu merged commit a0b9077 into main Sep 27, 2021
@dougbu dougbu deleted the halter73/sdk branch September 27, 2021 20:56
@ghost ghost added this to the 7.0-preview1 milestone Sep 27, 2021
@dsplaisted
Copy link
Member

I'm only seeing @(KnownFrameworkReference) items with %(TargetFramework) metadata for netcoreapp3.0, netcoreapp3.1, net5.0, and net6.0. Why isn't net7.0 in there yet❔

net7.0 targeting support is (hopefully) coming in dotnet/installer#11750.

(Side note: Why is the SDK still carting around netcoreapp3.0❔)

We want people to use the latest SDK, so it will still support building projects targeting .NET Core 1.0 (which didn't use KnownFrameworkReference items, which is why you don't see them prior to version 3). There's not much payload in the .NET SDK for these older versions, pretty much just version numbers which are listed in the BundledVersions props file.

@ghost
Copy link

ghost commented Sep 28, 2021

Hi @dsplaisted. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants