-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Obsolete LeakTrackingObjectPool and LeakTrackingObjectPoolProvider #43106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete LeakTrackingObjectPool and LeakTrackingObjectPoolProvider #43106
Conversation
| /// </para> | ||
| /// </summary> | ||
| /// <typeparam name="T">The type of object which is being pooled.</typeparam> | ||
| [Obsolete("LeakTrackingObjectPool<T> was only intended for use in diagnostic builds and may be removed in a future release.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text "was only intended for use in diagnostic builds" can be interpreted as referring to the user's diag builds of user-code, not Microsoft's builds of the CLR+EE.
I'd phrase it like this, perhaps:
"LeakTrackingObjectPool is only functional in diagnostic builds of the .NET CLR and EE. It does not function in GA/release builds of .NET used by the general public. This type may be removed in a future release."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jehoel. It doesn't actually need a special CLR build to work, but I understand your feedback. How about:
LeakTrackingObjectPool<T>was only intended for use in diagnostic builds of .NET. It does not function in any publicly shipped .NET versions and may be removed in a future release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [Obsolete("LeakTrackingObjectPool<T> was only intended for internal use in diagnostic builds of .NET. It does not " + | |
| "function in any publicly shipped .NET versions and may be removed in a future release.")] | |
| [Obsolete("LeakTrackingObjectPool<T> was only intended for internal use in diagnostic builds of .NET. It never " + | |
| "functioned in any publicly shipped .NET version and may be removed in a future release.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [Obsolete("LeakTrackingObjectPoolProvider was only intended for internal use in diagnostic builds of .NET. It does not " + | |
| "function in any publicly shipped .NET versions and may be removed in a future release.")] | |
| [Obsolete("LeakTrackingObjectPoolProvider was only intended for internal use in diagnostic builds of .NET. It never " + | |
| "functioned in any publicly shipped .NET version and may be removed in a future release.")] |
4590427 to
675c5fd
Compare
LeakTrackingObjectPooldoesn't work on release builds, and nothing else depends on it, so we've chosen to mark it (andLeakTrackingObjectPoolProvider) obsolete.Address #42524