Skip to content

Fix route handler analyzer test culture warnings #43107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JamesNK merged 1 commit into from
Aug 9, 2022
Merged

Fix route handler analyzer test culture warnings #43107

JamesNK merged 1 commit into from
Aug 9, 2022

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 5, 2022 •
edited
Loading

Fixes:

66>C:\Development\Source\aspnetcore\src\Framework\AspNetCoreAnalyzers\test\RouteHandlers\DisallowReturningActionResultsFromMapMethodsTest.cs(131,186,131,209): warning CA1305: The behavior of '{0}' could vary based on the current user's locale settings. Provide a value for the 'IFormatProvider' argument.
66>C:\Development\Source\aspnetcore\src\Framework\AspNetCoreAnalyzers\test\RouteHandlers\DisallowReturningActionResultsFromMapMethodsTest.cs(154,186,154,209): warning CA1305: The behavior of '{0}' could vary based on the current user's locale settings. Provide a value for the 'IFormatProvider' argument.
66>C:\Development\Source\aspnetcore\src\Framework\AspNetCoreAnalyzers\test\RouteHandlers\DisallowReturningActionResultsFromMapMethodsTest.cs(182,187,182,210): warning CA1305: The behavior of '{0}' could vary based on the current user's locale settings. Provide a value for the 'IFormatProvider' argument.
66>C:\Development\Source\aspnetcore\src\Framework\AspNetCoreAnalyzers\test\RouteHandlers\DisallowReturningActionResultsFromMapMethodsTest.cs(214,187,214,210): warning CA1305: The behavior of '{0}' could vary based on the current user's locale settings. Provide a value for the 'IFormatProvider' argument.
66>C:\Development\Source\aspnetcore\src\Framework\AspNetCoreAnalyzers\test\RouteHandlers\DisallowReturningActionResultsFromMapMethodsTest.cs(252,187,252,210): warning CA1305: The behavior of '{0}' could vary based on the current user's locale settings. Provide a value for the 'IFormatProvider' argument.

@JamesNK JamesNK added the old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Aug 5, 2022
@JamesNK JamesNK requested a review from Pilchie as a code owner August 5, 2022 05:11
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 5, 2022
captainsafia
captainsafia approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

When do these warnings occur? My understanding was that our analyzers were only running on src directories.

@JamesNK
Copy link
Member Author

JamesNK commented Aug 9, 2022

I got them when building this project in VS 17.4 Int Preview. Not sure why.

Doesn't hurt to fix them, but if there are more warnings from this project or VS 17.4 then we should investigate.

@JamesNK JamesNK merged commit e93acd5 into main Aug 9, 2022
@JamesNK JamesNK deleted the jamesnk/fix-culture-errors branch August 9, 2022 03:45
@ghost ghost added this to the 7.0-rc1 milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@captainsafia captainsafia captainsafia approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels

Projects

None yet

Milestone

7.0-rc1

Development

Successfully merging this pull request may close these issues.

3 participants

@JamesNK @captainsafia