Skip to content

Fix non-shared framework packages referencing transport package #43784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrennanConroy merged 8 commits into from
Sep 8, 2022
Merged

Fix non-shared framework packages referencing transport package #43784

BrennanConroy merged 8 commits into from
Sep 8, 2022

Conversation

@BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy commented Sep 6, 2022

Fixes #43726

@ghost ghost added the area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI label Sep 6, 2022
@wtgodbe wtgodbe requested review from a team, dougbu and wtgodbe as code owners September 6, 2022 22:10
@wtgodbe
Copy link
Member

wtgodbe commented Sep 6, 2022

I also updated this so that the auto-reference to Microsoft.Internal.Runtime.AspNetCore.Transport is only added to SharedFx projects. This should prevent us from hitting this problem again going forward

@BrennanConroy BrennanConroy changed the title Reference implementation of Configuration.Binder for user-jwt tool Fix non-shared framework packages referencing transport package Sep 6, 2022
@BrennanConroy
Copy link
Member Author

BrennanConroy commented Sep 6, 2022 •
edited
Loading

@Pilchie for RC2. This fixes an issue where the user-jwt isn't usable. Sadly, RC1 will be broken, but we've root caused the issue and fixed the root cause in addition to fixing the tool.

@BrennanConroy BrennanConroy added this to the 7.0-rc2 milestone Sep 6, 2022
@Pilchie
Copy link
Member

Pilchie commented Sep 6, 2022

Approved for .NET 7 RC2

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Sep 7, 2022 •
edited
Loading

@wtgodbe Security/Negotiate and ApiAuthorization.IdentityServer were failing locally. The grpc transcoding one didn't fail locally for me, but I guessed at the reason it failed. See latest 2 commits.

@BrennanConroy BrennanConroy merged commit f897de5 into release/7.0 Sep 8, 2022
@BrennanConroy BrennanConroy deleted the brecon/fixjwt branch September 8, 2022 00:07
@BrennanConroy BrennanConroy mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunolins16 brunolins16 brunolins16 approved these changes

@DamianEdwards DamianEdwards Awaiting requested review from DamianEdwards

@Pilchie Pilchie Awaiting requested review from Pilchie

@dougbu dougbu Awaiting requested review from dougbu

@wtgodbe wtgodbe Awaiting requested review from wtgodbe

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

No one assigned

Labels

area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI

Projects

None yet

Milestone

7.0-rc2

Development

Successfully merging this pull request may close these issues.

5 participants

@BrennanConroy @wtgodbe @Pilchie @brunolins16