Default install Playwright to false #43811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
requested review from
a team,
dougbu and
wtgodbe
as code owners
ghost
added
the
area-infrastructure
wtgodbe
approved these changes
Sep 7, 2022
Member
Author
|
Verified in logs that test runs skip playwright now. |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
dougbu
approved these changes
Sep 8, 2022
Contributor
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that every helix test run was installing playwright which is super unnecessary. This is because for some reason System.CommandLine treats anything other than "false" as true when using
parseResult.ValueForOption<bool>("--playwright");, and since we were passingstring.Emptyit defaulted to true.