Skip to content

[release/7.0] Send 431 when HTTP/2&3 headers are too large or many #44767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dougbu merged 5 commits into from
Nov 4, 2022
Merged

[release/7.0] Send 431 when HTTP/2&3 headers are too large or many #44767

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b77a059
Send 431 when HTTP/2 headers are too large or many #17861
Tratcher Oct 20, 2022
2e24a30
Send 431 when HTTP/2 headers are too large or many #33622
Tratcher Oct 20, 2022
7a23867
Fix test encoder
Tratcher Oct 21, 2022
ef8b59b
PR feedback
Tratcher Oct 25, 2022
faafeb8
Rework count enforcement
Tratcher Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test encoder
  • Loading branch information
@Tratcher
Tratcher authored and github-actions committed Oct 27, 2022
commit 7a23867c4e16d8e62f52a053835e15c75e620bc9
7 changes: 3 additions & 4 deletions src/Servers/Kestrel/shared/test/Http3/Http3InMemory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ internal async Task WaitForStreamErrorAsync(Http3ErrorCode protocolError, Action

internal class Http3RequestHeaderHandler
{
public readonly byte[] HeaderEncodingBuffer = new byte[64 * 1024];
public readonly byte[] HeaderEncodingBuffer = new byte[96 * 1024];
public readonly QPackDecoder QpackDecoder = new QPackDecoder(8192);
public readonly Dictionary<string, string> DecodedHeaders = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
}
Expand Down Expand Up @@ -697,10 +697,9 @@ public async Task SendHeadersAsync(Http3HeadersEnumerator headers, bool endStrea

var buffer = _headerHandler.HeaderEncodingBuffer.AsMemory();
var done = QPackHeaderWriter.BeginEncodeHeaders(headers, buffer.Span, ref headersTotalSize, out var length);
while (!done)
if (!done)
{
await SendFrameAsync(Http3FrameType.Headers, buffer.Slice(0, length), endStream: false);
done = QPackHeaderWriter.Encode(headers, buffer.Span, ref headersTotalSize, out length);
throw new InvalidOperationException("The headers are too large.");
}
await SendFrameAsync(Http3FrameType.Headers, buffer.Slice(0, length), endStream);
}
Expand Down