Skip to content

Enable throw helper analyzers #45954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesNK merged 15 commits into from
Jan 10, 2023
Merged

Enable throw helper analyzers #45954

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d61da52
Enable throw helper analyzers
JamesNK Jan 9, 2023
721af94
Additional fixes
JamesNK Jan 9, 2023
8e8fb07
More
JamesNK Jan 9, 2023
945d70a
Fix
JamesNK Jan 9, 2023
a507d27
Fix
JamesNK Jan 9, 2023
3dee9b0
Fix
JamesNK Jan 9, 2023
d88a2a4
Fix
JamesNK Jan 9, 2023
715297e
Fix
JamesNK Jan 9, 2023
d0ef696
Fix
JamesNK Jan 9, 2023
ad32251
Whitespace
JamesNK Jan 9, 2023
daf88e0
More
JamesNK Jan 9, 2023
2f3613a
PR feedback
JamesNK Jan 9, 2023
1a06074
Update src/Shared/ThrowHelpers/ArgumentOutOfRangeThrowHelper.cs
JamesNK Jan 9, 2023
8740f42
PR feedback
JamesNK Jan 9, 2023
d5e79bd
React to changes
JamesNK Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix
  • Loading branch information
@JamesNK
JamesNK committed Jan 9, 2023
commit 3dee9b0b0546c91375d0ceb424468acc5b307c03
3 changes: 2 additions & 1 deletion Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@

<!-- Ignore analyzers that recommend APIs introduced in .NET Core when targeting frameworks that lack those APIs
to avoid issues with multitargeting.
Some projects only build DefaultNetCoreTargetFramework when DotNetBuildFromSource is true so also suppress for source build.
-->
<NoWarn Condition="$(TargetFrameworks.Contains('NetFramework')) or $(TargetFrameworks.Contains('netstandard'))">$(NoWarn);CA1510;CA1511;CA1512;CA1513</NoWarn>
<NoWarn Condition="$(TargetFrameworks.Contains('NetFramework')) or $(TargetFrameworks.Contains('netstandard')) or '$(DotNetBuildFromSource)' == 'true'">$(NoWarn);CA1510;CA1511;CA1512;CA1513</NoWarn>
</PropertyGroup>

<PropertyGroup Label="Resx settings">
Expand Down