Skip to content

Conversation

@github-actions
Copy link
Contributor

This PR was automatically generated to sync shared code changes from runtime. Fixes #18943

@eerhardt
Copy link
Member

@Tratcher @JamesNK - I didn't really know what I was doing in #47650, I was just trying to unblock the runtime flow.

How do we mark this file as "shouldn't be sync'd with runtime"? Like the SR.cs file is?

@JamesNK
Copy link
Member

JamesNK commented Apr 13, 2023

SR.cs is synced. Everything in this directory is. Mirror: https://github.com/dotnet/runtime/tree/main/src/libraries/Common/src/System/Net/Http/aspnetcore

You could add the file in runtime, or move it out of this directory in aspnetcore

@eerhardt
Copy link
Member

Can the owners of the shared code from runtime make the call here and fix it? My goal was just to get the runtime ingestion PR unblocked.

cc @ManickaP @MihaZupan @GrabYourPitchforks @dotnet/ncl

@Tratcher Tratcher enabled auto-merge (squash) April 14, 2023 19:42
@Tratcher
Copy link
Member

That should take care of it. I moved the copy of Obsoletions.cs into a shared folder that's not sync'd so it won't get overwritten.

@Tratcher Tratcher merged commit 8968058 into main Apr 14, 2023
@Tratcher Tratcher deleted the github-action/sync-runtime-1681373116 branch April 14, 2023 23:27
@ghost ghost added this to the 8.0-preview4 milestone Apr 14, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The runtime<->aspnetcore shared src is out of sync

5 participants