Skip to content

Defer search for dev cert until build bind time #48056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amcasey wants to merge 3 commits into from
Closed

Defer search for dev cert until build bind time #48056

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90ddbbc
Move HttpProtocols from HttpsConnectionAdapterOptions to HttpsConnect…
amcasey May 1, 2023
f8d3cd0
Defer search for dev cert until build bind time
amcasey May 2, 2023
904aec8
Pull DI lookups out of lambda
amcasey May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Pull DI lookups out of lambda
  • Loading branch information
@amcasey
amcasey committed May 4, 2023
commit 904aec8907ceef3d691047859ec520a85db85ac0
5 changes: 3 additions & 2 deletions src/Servers/Kestrel/Core/src/ListenOptionsHttpsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,13 +206,14 @@ private static ListenOptions UseHttps(this ListenOptions listenOptions, Lazy<Htt
listenOptions.IsTls = true;
listenOptions.HttpsOptions = lazyHttpsOptions;

var loggerFactory = listenOptions.KestrelServerOptions.ApplicationServices.GetRequiredService<ILoggerFactory>();
var metrics = listenOptions.KestrelServerOptions.ApplicationServices.GetRequiredService<KestrelMetrics>();

// NB: This lambda will only be invoked if either HTTP/1.* or HTTP/2 is being used
listenOptions.Use(next =>
{
// Evaluate the HttpsConnectionAdapterOptions, now that the configuration, if any, has been loaded
var httpsOptions = lazyHttpsOptions.Value;
var loggerFactory = listenOptions.KestrelServerOptions.ApplicationServices.GetRequiredService<ILoggerFactory>();
var metrics = listenOptions.KestrelServerOptions.ApplicationServices.GetRequiredService<KestrelMetrics>();
var middleware = new HttpsConnectionMiddleware(next, httpsOptions, listenOptions.Protocols, loggerFactory, metrics);
return middleware.OnConnectionAsync;
});
Expand Down