Skip to content

Http.Sys: Clean up Request parsing errors #57531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Http.Sys: Clean up Request parsing errors #57531

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdb3c43
Http.Sys: Clean up Request parsing errors
BrennanConroy Aug 15, 2024
a94d5cf
nit
BrennanConroy Aug 26, 2024
4365ba2
comment
BrennanConroy Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
comment
  • Loading branch information
@BrennanConroy
BrennanConroy committed Sep 11, 2024
commit 4365ba2ff6904ed4107e7447a0dc34d8dbbfc782
2 changes: 2 additions & 0 deletions src/Servers/HttpSys/src/RequestProcessing/RequestContext.FeatureCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ protected internal bool InitializeFeatures()
catch (Exception ex)
{
Log.RequestParsingError(Logger, ex);
// Synchronously calls Http.Sys and tells it to send an http response
// No one has written to the response yet (haven't even created the response object below)
Server.SendError(_requestId.Value, StatusCodes.Status400BadRequest, authChallenges: null);
Copy link
Member

@amcasey amcasey Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not immediately obvious that this is a safe place to call SendError. What does it do? Is it synchronous? Does it schedule something? It doesn't depend on anything established by InitializeFeatures?

Copy link
Member Author

@BrennanConroy BrennanConroy Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a synchronous call, only state it needs from InitializeFeature is the request ID which we pass in. Would you like some sort of comment here mentioning it's a synchronous call to native code?

return false;
}
Expand Down