Skip to content

Initialize hosting trace with OTEL tags for sampling #62090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 19, 2025
Merged

Initialize hosting trace with OTEL tags for sampling #62090

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
272cc6f
Feature for setting activity tags on creation
rkarg-blizz May 23, 2025
67c6363
adding unshipped public API entries
rkarg-blizz May 23, 2025
2edbad5
moving to TagList
rkarg-blizz May 23, 2025
3fcaf85
Less specific property type
rkarg-blizz May 23, 2025
3ec3501
Update HostingApplicationDiagnostics.cs
rkargMsft Jun 17, 2025
de03968
unconditionally adding host/port tags to Activity creation
rkargMsft Jun 25, 2025
50cf8a9
correcting variable naming
rkargMsft Jun 25, 2025
af4426e
reverting HostAndPort property
rkargMsft Jun 25, 2025
8a8dcbb
naming
rkargMsft Jun 25, 2025
9a45fbf
Initialize hosting trace with OTEL tags for sampling
JamesNK Aug 15, 2025
4d29363
Default to off
JamesNK Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
correcting variable naming
  • Loading branch information
@rkargMsft @JamesNK
rkargMsft authored and JamesNK committed Aug 15, 2025
commit 50cf8a9be65ba6a50d5758fef1d06c42d92bc438
4 changes: 2 additions & 2 deletions src/Hosting/Hosting/src/Internal/HostingApplicationDiagnostics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,9 +390,9 @@ private void RecordRequestStartMetrics(HttpContext httpContext)
hasDiagnosticListener = false;

var tagsForCreation = new TagList();
if (_activitySource.HasListeners() && _context.Request.Host.HasValue)
if (_activitySource.HasListeners() && httpContext.Request.Host.HasValue)
{
var (host, port) = _context.Request.Host.HostAndPort;
var (host, port) = httpContext.Request.Host.HostAndPort;
tags.Add("server.address", host);
if (port is not null)
{
Expand Down