Skip to content

Fix OpenApiJsonSchema array parsing (#62051) #62118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Fix OpenApiJsonSchema array parsing (#62051) #62118

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49bdeaf
Fix OpenApiJsonSchema array parsing (#62051)
BrennanConroy May 27, 2025
5a082f0
translate
BrennanConroy May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
translate
  • Loading branch information
@BrennanConroy
BrennanConroy committed May 27, 2025
commit 5a082f0e454039d7d0cb488c182cd51a5af8daf8
8 changes: 4 additions & 4 deletions ...Core.OpenApi.Tests/Services/OpenApiSchemaService/OpenApiSchemaService.ParameterSchemas.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,10 +742,10 @@ public async Task CustomConverterThatOutputsArrayWithDefaultValue()
// Assert
await VerifyOpenApiDocument(builder, document =>
{
var operation = document.Paths["/api"].Operations[HttpMethod.Post];
var operation = document.Paths["/api"].Operations[OperationType.Post];
var param = Assert.Single(operation.Parameters);
Assert.NotNull(param.Schema);
Assert.IsType<JsonArray>(param.Schema.Default);
Assert.IsType<OpenApiArray>(param.Schema.Default);
// Type is null, it's up to the user to configure this via a custom schema
// transformer for types with a converter.
Assert.Null(param.Schema.Type);
Expand All @@ -769,10 +769,10 @@ public async Task CustomConverterThatOutputsObjectWithDefaultValue()
// Assert
await VerifyOpenApiDocument(builder, document =>
{
var operation = document.Paths["/api"].Operations[HttpMethod.Post];
var operation = document.Paths["/api"].Operations[OperationType.Post];
var param = Assert.Single(operation.Parameters);
Assert.NotNull(param.Schema);
Assert.IsType<JsonObject>(param.Schema.Default);
Assert.IsType<OpenApiObject>(param.Schema.Default);
// Type is null, it's up to the user to configure this via a custom schema
// transformer for types with a converter.
Assert.Null(param.Schema.Type);
Expand Down
Loading