This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Add tests for RestoreUseStaticGraphEvaluation #13374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@joeloff could you review this? the branch is open right? |
Member
|
Branch should be open. Regarding the tests, it seems that regardless of the property, the results are expected to be the same. Are there situations where not using the static evaluation would produce different results, or is this purely for perf gains? |
Author
|
It is part of dotnet/toolset#4583 It is porting dotnet/sdk#10794 @ViktorHofer for the question |
Member
|
Purely perf gain. The NuGet cache, dgspec and other files should be the same with both modes. cc @jeffkl who wrote the static graph restore feature. |
Author
|
good to merge ? @joeloff |
joeloff
approved these changes
Jun 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/sdk#11420
Wait after 5/26 need dotnet/toolset#4583 get in first and then update stage 0