Skip to content

Remove Argument.AllowedValues, use Validator to implement the logic #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 6 commits into from
Dec 15, 2022
Merged

Remove Argument.AllowedValues, use Validator to implement the logic #1959

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2411731
delay List<Validators> allocation
adamsitnik Nov 10, 2022
29940bb
delegate Option.AcceptOnlyFromAmong to Argument.AcceptOnlyFromAmong
adamsitnik Nov 10, 2022
d2b0206
use Validator to implement AllowedValues
adamsitnik Nov 10, 2022
36b179c
Merge remote-tracking branch 'upstream/main' into removeAllowedValues
adamsitnik Dec 15, 2022
f517c35
remove redundant line
adamsitnik Dec 15, 2022
1cb1e9a
add a missing failing test and a fix for it
adamsitnik Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
delegate Option.AcceptOnlyFromAmong to Argument.AcceptOnlyFromAmong
  • Loading branch information
@adamsitnik
adamsitnik committed Nov 10, 2022
commit 29940bba27caee4842fd668787683d545eba8153
5 changes: 1 addition & 4 deletions src/System.CommandLine/Option.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,10 +242,7 @@ public override IEnumerable<CompletionItem> GetCompletions(CompletionContext con
/// <returns>The configured option.</returns>
public Option AcceptOnlyFromAmong(params string[] values)
{
Argument.AllowedValues?.Clear();
Argument.AddAllowedValues(values);
Argument.Completions.Clear();
Argument.Completions.Add(values);
Argument.AcceptOnlyFromAmong(values);

return this;
}
Expand Down