Skip to content

UnrecognizedArgument error should mention first invalid argument, not the last one #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 3 commits into from
Jan 20, 2023
Merged

UnrecognizedArgument error should mention first invalid argument, not the last one #2029

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5da32ad
add a failing test
adamsitnik Jan 20, 2023
5f5936f
fix
adamsitnik Jan 20, 2023
3f12d0e
Apply suggestions from code review
adamsitnik Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Jon Sequeira <[email protected]>
  • Loading branch information
@adamsitnik @jonsequitur
adamsitnik and jonsequitur authored Jan 20, 2023
commit 3f12d0e4fa5923811c860956564c153f421ad3bf
4 changes: 2 additions & 2 deletions src/System.CommandLine.Tests/ParsingValidationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,12 +178,12 @@ public void When_FromAmong_is_used_and_multiple_invalid_inputs_are_provided_the_
option.Arity = new ArgumentArity(1, 4);
option.AllowMultipleArgumentsPerToken = true;

var command = new Command("--list")
var command = new Command("list")
{
option
};

var result = command.Parse("--list --columns c1 c2");
var result = command.Parse("list --columns c1 c2");

// Currently there is no possibility for a single validator to produce multiple errors,
// so only the first one is checked.
Expand Down