This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Revert "Enable hosted builds on arm64 (#7696)" #7806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4b82b1e. The changes break VS and may even change the default on Windows to x86 instead of x64.
vitek-karas
approved these changes
Aug 22, 2019
| <MicrosoftDiaSymReaderNativePackageVersion>1.7.0</MicrosoftDiaSymReaderNativePackageVersion> | ||
| <!-- Infrastructure and test-only. --> | ||
| <MicrosoftSourceLinkVersion>1.0.0-beta2-19367-01</MicrosoftSourceLinkVersion> | ||
| <MicrosoftSourceLinkVersion>1.0.0-beta2-18618-05</MicrosoftSourceLinkVersion> |
Member
There was a problem hiding this comment.
Do we want to keep the latest SourceLink? It sounds like that should be OK, right?
Member
Author
There was a problem hiding this comment.
I plan to do new PR for arm64 (hopefully that will not break everything). That PR will re-bump the SourceLink version. Do you think I should keep the bumped sourcelink version here?
Member
There was a problem hiding this comment.
In theory, I think including this in the revert is nice, so git blame on this line will point to the new PR rather than the old reverted one. Simple reverts are easier to keep track of. Very unlikely that will practically matter though.
If there are some practical benefits we've started depending on with the new version, that would be another story, I suppose.
dagood
approved these changes
Aug 22, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…et/core-setup#7806) This reverts commit dotnet/core-setup@4b82b1e. The changes break VS and may even change the default on Windows to x86 instead of x64. Commit migrated from dotnet/core-setup@a307f0d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4b82b1e.
The changes break VS and may even change the default on Windows to x86
instead of x64.
See #7696 for some comments on the consequences.