This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Make upgrade install new host first, then uninstall old #9184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should preserve the ordering of PATH, since the old MSI will never remove its entry.
NikolaMilosavljevic
approved these changes
Oct 13, 2021
joeloff
approved these changes
Oct 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of dotnet/runtime#60307 and dotnet/arcade#8025 to core-setup/release/3.1
Customer Impact
Customers installing upgrades of .NET 3.1 observe the entry for dotnet will move to the end of the PATH variable, often resulting in x86 dotnet being first and winning.
Testing
Manual build of host and upgrade testing. I've tested upgrade scenarios where 5.0 x86 + x64 is installed. Upgrade to 6.0 x64 without the fix will move x64 PATH to end. Once fix is in place we don't move PATH entry.
Risk
Low. This doesn't change installer behavior like some of the other options we considered. The change is scoped to only the host MSI