Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Improve hardware intrinsic tests #21361

Merged
CarolEidt merged 2 commits into from
Dec 7, 2018
Merged

Improve hardware intrinsic tests #21361

CarolEidt merged 2 commits into from
Dec 7, 2018

Conversation

@fiigii
Copy link

@fiigii fiigii commented Dec 4, 2018

This PR removes redundant checks for 64-bit intrinsics #21264 (comment) and moves more Sse2 and Sse2.X64 intrinsic tests into templates.

@fiigii
Copy link
Author

fiigii commented Dec 4, 2018

@dotnet-bot test Windows_NT x64 Checked jitsse2only
@dotnet-bot test Windows_NT x64 Checked jitincompletehwintrinsic
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Windows_NT x64 Checked jitx86hwintrinsicnosimd
@dotnet-bot test Windows_NT x64 Checked jitnox86hwintrinsic

@dotnet-bot test Windows_NT x86 Checked jitsse2only
@dotnet-bot test Windows_NT x86 Checked jitincompletehwintrinsic
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Windows_NT x86 Checked jitx86hwintrinsicnosimd
@dotnet-bot test Windows_NT x86 Checked jitnox86hwintrinsic

@dotnet-bot test Ubuntu x64 Checked jitsse2only
@dotnet-bot test Ubuntu x64 Checked jitincompletehwintrinsic
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnoavx
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnoavx2
@dotnet-bot test Ubuntu x64 Checked jitx86hwintrinsicnosimd
@dotnet-bot test Ubuntu x64 Checked jitnox86hwintrinsic

tannergooding
tannergooding approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fiigii
Copy link
Author

fiigii commented Dec 5, 2018

@dotnet-bot test Ubuntu x64 Checked jitincompletehwintrinsic

@fiigii
Copy link
Author

fiigii commented Dec 5, 2018

@tannergooding Could you please merge this?

@tannergooding
Copy link
Member

tannergooding commented Dec 5, 2018

This one should have at least one other sign-off.

@fiigii
Copy link
Author

fiigii commented Dec 7, 2018

@CarolEidt ping?

CarolEidt
CarolEidt approved these changes Dec 7, 2018
View reviewed changes
Copy link

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarolEidt CarolEidt merged commit 02d37e4 into dotnet:master Dec 7, 2018
@fiigii fiigii deleted the x64tests branch December 11, 2018 23:09
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@CarolEidt
Merge pull request dotnet/coreclr#21361 from fiigii/x64tests
b08d453 
Improve hardware intrinsic tests

Commit migrated from dotnet/coreclr@02d37e4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@CarolEidt CarolEidt CarolEidt approved these changes

@tannergooding tannergooding tannergooding approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fiigii @tannergooding @CarolEidt @FeiPengIntel