This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Allow creating typehandles to TypedReference*
#25817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unclear why this was disallowed - we allow them in method signatures and there's a comment a couple lines below the code I'm touching saying we thought about blocking this for byref-like types, but there's no reason to do that. `TypedReference` is the original byref-like type.
jkotas
approved these changes
Jul 23, 2019
VSadov
approved these changes
Jul 23, 2019
Member
VSadov
left a comment
VSadov
left a comment
There was a problem hiding this comment.
Indeed, C# may disallow ref TypedReference for historical reasons, but TypedReference* is clearly supported.
Member
|
C# could allow Anyways - no reason to disallow in the runtime. |
monojenkins
pushed a commit
to monojenkins/mono
that referenced
this pull request
Aug 7, 2020
…eflection. CoreCLR gained support for creating`TypedReference *` and `TypedReference &` via `MakePointerType` and `MakeByRefType` in dotnet/coreclr#25817. Reenable byref System.Void-related reflection tests. Fixes dotnet/runtime#31713. Fixes dotnet/runtime#37489.
imhameed
added a commit
to dotnet/runtime
that referenced
this pull request
Aug 7, 2020
…eflection. (#40472) CoreCLR gained support for creating`TypedReference *` and `TypedReference &` via `MakePointerType` and `MakeByRefType` in dotnet/coreclr#25817. Reenable byref System.Void-related reflection tests. Fixes #31713. Fixes #37489.
imhameed
added a commit
to mono/mono
that referenced
this pull request
Aug 7, 2020
…eflection. (#20221) CoreCLR gained support for creating`TypedReference *` and `TypedReference &` via `MakePointerType` and `MakeByRefType` in dotnet/coreclr#25817. Reenable byref System.Void-related reflection tests. Fixes dotnet/runtime#31713. Fixes dotnet/runtime#37489. Co-authored-by: imhameed <[email protected]>
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
…eflection. (dotnet#40472) CoreCLR gained support for creating`TypedReference *` and `TypedReference &` via `MakePointerType` and `MakeByRefType` in dotnet/coreclr#25817. Reenable byref System.Void-related reflection tests. Fixes dotnet#31713. Fixes dotnet#37489.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
It's unclear why this was disallowed - we allow them in method signatures and there's a comment a couple lines below the code I'm touching saying we thought about blocking this for byref-like types, but there's no reason to do that. `TypedReference` is the original byref-like type. Commit migrated from dotnet/coreclr@2354d0b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear why this was disallowed - we allow them in method signatures and there's a comment a couple lines below the code I'm touching saying we thought about blocking this for byref-like types, but there's no reason to do that.
TypedReferenceis the original byref-like type.Fixes #25697.