This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Setup the CoreCLR repo to use the LocalPackagePublish mechanism. #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dir.props
Outdated
Member
There was a problem hiding this comment.
I assume you want this to be version 8.
Member
There was a problem hiding this comment.
Also any reason these aren't in the dir.props file? At least the version number here so it can be in a consistent location across repos.
Author
There was a problem hiding this comment.
I will update this to the latest version of buildtools.
I will also move these to the dir.props file. No reason they should be here.
Author
There was a problem hiding this comment.
These are already in the dir.props file.
Member
There was a problem hiding this comment.
Well why don't you move them to where they already are! :)
AlexGhiondea
force-pushed
the
localPublish
branch
from
1304e36 to
4645022
Compare
This will enable the 'local publish' of the CoreCLR package to a location where it can be picked up by the CoreFx build. What this means is that you will be able to build the CoreCLR package and use that to run the CoreFx tests on top of it. Changes required to make this happen: - Refactor the managed build to make sure the buildtools gets restored before we attempt to use the targets it provides. - Take a dependency to the Microsoft.DotNet.BuildTools to bring in the packages.targets - Update the $(PackagesDir) to point to the <repo root>\packages to make it consistent with CoreFx - Hook-up the LocalPackagePublish targets to the build of the CoreCLR NuGet packages
AlexGhiondea
force-pushed
the
localPublish
branch
from
4645022 to
fbc318c
Compare
Member
|
LGTM |
AlexGhiondea
added a commit
that referenced
this pull request
Feb 20, 2015
Setup the CoreCLR repo to use the LocalPackagePublish mechanism.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable the 'local publish' of the CoreCLR package to a location where it can be picked up by the CoreFx build.
What this means is that you will be able to build the CoreCLR package and use that to run the CoreFx tests on top of it.
Changes required to make this happen: