Throw InvalidProgramException when VarArgs are encountered #5124
Conversation
|
LGTM |
|
@dotnet-bot test Windows_NT x86 legacy_backend Checked Build and Test please |
|
@dotnet-bot test CentOS7.1 x64 Debug Build and Test please |
|
@janvorli Are you aware of this failure in CentOS? http://dotnet-ci.cloudapp.net/job/dotnet_coreclr/job/master/job/debug_centos7.1_prtest/1634/ |
|
@janvorli Thoughts? |
|
@gkhanna79 this is a new test that @kouvel has added yesterday when checking in the cross process named mutexes stuff. He has a PR pending with a fix for some issues he has discovered later. @kouvel - is the error in the test something that you'd expect to be fixed by your pending change? |
|
This seems like a new issue - basic named mutex creation is failing. I suspect it's an intermittent issue, I'll take a look. |
|
@kouvel Thank you. I would like to merge this PR today, so please let me know if you think this test failure would be a blocker. |
|
I don't think it's related to your change, so it shouldn't block your change. It may pass on rerun, this may be something special about that machine. |
|
I can continue to investigate this separately |
|
Thank you. I will merge the PR. |
gkhanna79
changed the title
Throw InvalidProgramException when VarArgs are encountered Commit migrated from dotnet/coreclr@18110e9
Add same exclusions as added for other platforms in dotnet/coreclr#5124. These were missed because we don't have JIT32 testing on dotnet-ci. Commit migrated from dotnet/coreclr@ac81aaf
6 participants
@jkotas PTAL