-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Add HasSameMetadataDefinitionAs(). #20112
Conversation
|
Cannot merge until dotnet/coreclr#11774 propagates to corefx (and preferably, corert implementation checked in.) |
|
Finally, CoreCLR was updated... |
|
@dotnet-bot test Linux x64 Tests - Release - Debian.87.Amd64.Open |
2 similar comments
|
@dotnet-bot test Linux x64 Tests - Release - Debian.87.Amd64.Open |
|
@dotnet-bot test Linux x64 Tests - Release - Debian.87.Amd64.Open |
|
@atsushikan what's the status of this PR? 11 days no update ... |
What it needs it is somebody to approve it. |
|
@dotnet-bot test Portable Windows x64 Release Build |
OK, are you driving that? BTW: That's why the PR is assigned to you, the (MS) author - you are expected to take action, get code reviews, chase down people, etc. |
VSadov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In particular since this is just exposing emplementation from dotnet/coreclr#11774 and adding tests.
This api was approved here:
Fix https://github.com/dotnet/corefx/issues/5884
and is a necessary step to fixing the System.Dynamic.Runtime.Tests
failure:
https://github.com/dotnet/corefx/issues/19895
which is caused by Microsoft.CSharp trying to do the impossible
and emulate this api without GetMetadataToken() support.
CoreCLR implementation here:
dotnet/coreclr#11774
and CoreRT implementation in CR: