This repository was archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Move Span APIs that allow skipping visibility checks to MemoryMarshal #28296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrzysztofCwalina
approved these changes
Mar 21, 2018
Member
|
@dotnet-bot test this please |
Member
|
Member
|
@dotnet-bot test this please |
GrabYourPitchforks
approved these changes
Mar 23, 2018
Author
|
Closing this PR as the commits got cherry-picked into the mirror PR - #28384 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/dotnet/corefx/issues/27094
TODO: Remove AsBytes extension method once all calls have been changed to MemoryMarshal
Depends on the PR from coreclr (along with the mirror PR) - dotnet/coreclr#17087 / dotnet/coreclr#17106. It will fail CI until then.
cc @jkotas, @KrzysztofCwalina, @dotnet/corefxlab-contrib