Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@ahsonkhan
Copy link

@ahsonkhan ahsonkhan commented Mar 21, 2018

Resolves https://github.com/dotnet/corefx/issues/27094

TODO: Remove AsBytes extension method once all calls have been changed to MemoryMarshal

Depends on the PR from coreclr (along with the mirror PR) - dotnet/coreclr#17087 / dotnet/coreclr#17106. It will fail CI until then.

cc @jkotas, @KrzysztofCwalina, @dotnet/corefxlab-contrib

@jkotas
Copy link
Member

jkotas commented Mar 22, 2018

@dotnet-bot test this please

@joshfree
Copy link
Member

09:05:16 Build FAILED.
09:05:16 
09:05:16 Perf.Span.BinaryReadAndWrite.cs(29,38): error CS0103: The name 'ReadMachineEndian' does not exist in the current context [D:\j\workspace\windows-TGrou---74aa877a\src\System.Memory\tests\Performance\System.Memory.Performance.Tests.csproj]
09:05:16 Perf.Span.BinaryReadAndWrite.cs(64,38): error CS0103: The name 'ReadMachineEndian' does not exist in the current context [D:\j\workspace\windows-TGrou---74aa877a\src\System.Memory\tests\Performance\System.Memory.Performance.Tests.csproj]
09:05:16     0 Warning(s)
09:05:16     2 Error(s)
09:05:16 
09:05:16 Time Elapsed 00:01:16.06
09:05:16 Command execution failed with exit code 1.

@ahsonkhan ahsonkhan removed the blocked Issue/PR is blocked on something - see comments label Mar 22, 2018
@stephentoub
Copy link
Member

@dotnet-bot test this please

@ahsonkhan
Copy link
Author

Closing this PR as the commits got cherry-picked into the mirror PR - #28384

@ahsonkhan ahsonkhan closed this Mar 23, 2018
@ahsonkhan ahsonkhan deleted the MoveToMemMarshal branch March 23, 2018 05:49
@karelz karelz added this to the 2.1.0 milestone Mar 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants