This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add back the missing code that handle source=="vals[i]" code. #31590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mganss
reviewed
Aug 10, 2018
| } | ||
|
|
||
| [Fact] | ||
| public static void DeserializeIEREFSIntoStringTest() |
There was a problem hiding this comment.
Typo: Should be DeserializeIDREFSIntoStringTest()
Contributor
Author
|
@mconnew Could you do code review? |
Member
|
The current code looks good, but what about codegen and reflection based serializers? |
Member
|
@huanwu any update on the PR? There hasn't been any for last 3 weeks ... |
Contributor
Author
mconnew
reviewed
Sep 13, 2018
| } | ||
|
|
||
| [Fact] | ||
| public static void DeserializeIEREFSIntoStringTest() |
Member
There was a problem hiding this comment.
Can you fix the naming of this function. It should be IDREFS
Member
|
The code needs to be rebased. Once the typo has been fixed, this LGTM. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…/corefx#31590) * Add back the missing code that handle source=="vals[i]" code. * Move tests to XmlSerializerTests.cs so it will run in sgen test project. * Fix name Commit migrated from dotnet/corefx@4665fb8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31330
@mconnew @Lxiamail @yujayee