This repository was archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Small code duplication eliminated in RbTree classs #32490
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght child or it is NIL) in RBDeleteFixup method
stephentoub
approved these changes
Sep 26, 2018
Member
stephentoub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Contributor
Author
|
Sorry, closed PR by mistake. Opened it again |
Member
|
@aegoroff, this PR now contains a whole bunch of unrelated changes. Can you please squash it down to just the relevant changes? |
Contributor
Author
Sure, i'll try to remove them |
Contributor
Author
done |
stephentoub
approved these changes
Sep 27, 2018
Member
stephentoub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Contributor
Author
|
don't mention it :) |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ght child or it is NIL) in RBDeleteFixup method (dotnet/corefx#32490) Commit migrated from dotnet/corefx@3a35949
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useless if (same code in both alternatives) and code duplication eliminated within branch (//x is a right child or it is NIL) in RBDeleteFixup method