Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@aegoroff
Copy link
Contributor

@aegoroff aegoroff commented Sep 26, 2018

Useless if (same code in both alternatives) and code duplication eliminated within branch (//x is a right child or it is NIL) in RBDeleteFixup method

…ght child or it is NIL) in RBDeleteFixup method
@dnfclas
Copy link

dnfclas commented Sep 26, 2018

CLA assistant check
All CLA requirements met.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@aegoroff aegoroff closed this Sep 27, 2018
@aegoroff aegoroff reopened this Sep 27, 2018
@aegoroff
Copy link
Contributor Author

Sorry, closed PR by mistake. Opened it again

@stephentoub
Copy link
Member

@aegoroff, this PR now contains a whole bunch of unrelated changes. Can you please squash it down to just the relevant changes?

@aegoroff
Copy link
Contributor Author

@aegoroff, this PR now contains a whole bunch of unrelated changes. Can you please squash it down to just the relevant changes?

Sure, i'll try to remove them

@aegoroff
Copy link
Contributor Author

@aegoroff, this PR now contains a whole bunch of unrelated changes. Can you please squash it down to just the relevant changes?

done

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stephentoub stephentoub merged commit 3a35949 into dotnet:master Sep 27, 2018
@aegoroff
Copy link
Contributor Author

don't mention it :)

@karelz karelz added this to the 3.0 milestone Oct 8, 2018
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…ght child or it is NIL) in RBDeleteFixup method (dotnet/corefx#32490)

Commit migrated from dotnet/corefx@3a35949
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants