This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove test for unsupported delegate marshalling #32518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GetFunctionPointerForDelegateTests had one subtest that was testing that an attempt to use delegate marshalling in collectible types will result in an exception as it was not supported. But the support is coming in coreclr, so this test needs to be deleted.
Member
Author
|
@stephentoub I've discovered one more test that needs to be removed. |
Member
|
I assume there are new tests verifying things do work to replace the ones that verify things don't? |
stephentoub
approved these changes
Sep 27, 2018
Member
Author
There will be such tests - we will have a nightly run where all coreclr tests will be run inside of an unloadable AssemblyLoadContext. And later corefx ones too. I have all the building blocks for enabling the coreclr ones, but need to find a little time to polish it and integrate into the CI. |
Member
Author
|
@dotnet-bot test NETFX x86 Release Build please |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
The GetFunctionPointerForDelegateTests had one subtest that was testing that an attempt to use delegate marshalling in collectible types will result in an exception as it was not supported. But the support is coming in coreclr, so this test needs to be deleted. Commit migrated from dotnet/corefx@355000f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetFunctionPointerForDelegateTests had one subtest that was testing
that an attempt to use delegate marshalling in collectible types will
result in an exception as it was not supported. But the support is
coming in coreclr, so this test needs to be deleted.