This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Switch from BuildTools packaging to Arcade packaging #32901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericstj
requested review from
joperezr and
safern
and removed request for
joperezr
safern
approved these changes
Oct 18, 2018
Member
safern
left a comment
safern
left a comment
There was a problem hiding this comment.
This needs to be added into the Version.Details.xml if you want dependency auto updates 😄
joperezr
reviewed
Oct 18, 2018
| <add key="dotnet-core" value="https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json" /> | ||
| </packageSources> | ||
| <disabledPackageSources> | ||
| <clear /> |
Member
There was a problem hiding this comment.
NIT: Should we add a comment in here of why this is needed?
joperezr
approved these changes
Oct 18, 2018
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
Other than the small comment this LGTM
weshaggard
reviewed
Oct 18, 2018
| <MicrosoftDotNetGenApiPackage>Microsoft.DotNet.GenAPI</MicrosoftDotNetGenApiPackage> | ||
| <MicrosoftDotNetGenFacadesPackage>Microsoft.DotNet.GenFacades</MicrosoftDotNetGenFacadesPackage> | ||
| <MicrosoftDotNetXUnitExtensionsPackage>Microsoft.DotNet.XUnitExtensions</MicrosoftDotNetXUnitExtensionsPackage> | ||
| <MicrosoftDotNetBuildTasksPackagingPackage>Microsoft.DotNet.Build.Tasks.Packaging</MicrosoftDotNetBuildTasksPackagingPackage> |
Member
There was a problem hiding this comment.
I know you are just following convention but we might want to reconsider the package name duplication now if the only place the name is used is in Tools.props.
weshaggard
approved these changes
Oct 18, 2018
ericstj
force-pushed
the
arcade-packaging
branch
from
b7d6153 to
7a74114
Compare
Member
Author
|
Fixed the version XML 🌮 |
Member
Author
|
Test Linux arm64 Release Build |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Switch from BuildTools packaging to Arcade packaging Commit migrated from dotnet/corefx@4b36fba
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.