Fixes abbreviated genitive

[lillo42]

fixes bug: https://github.com/dotnet/corefx/issues/2804

Where can I add test? I didn't find any class to add test and how can I test this?

[ahsonkhan]

Where can I add test? I didn't find any class to add test and how can I test this?

Maybe in here?

corefx/src/System.Globalization/tests/DateTimeFormatInfo/DateTimeFormatInfoAbbreviatedMonthGenitiveNames.cs

Line 9 in a10890f

public class DateTimeFormatInfoAbbreviatedMonthGenitiveNames

OR

corefx/src/System.Runtime/tests/System/DateTimeTests.netcoreapp.cs

Line 10 in 51e1541

public static partial class DateTimeTests

cc @tarekgh

[danmoseley]

@lillo42 the code under CoreLib is not live, it is mirrored from the coreclr repo (it is not used for testing either -- just code reuse in some cases). Instead please make a PR with the fix in https://github.com/dotnet/coreclr/blob/master/src/System.Private.CoreLib/shared/System/Globalization/DateTimeFormat.cs. You can reuse this PR for the tests. Please link the PR's.

To run tests you have in CoreFX against fix you have in CoreCLR privately, please see https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/developer-guide.md#testing-with-private-coreclr-bits

[tarekgh]

please add the test on

corefx/src/System.Globalization/tests/DateTimeFormatInfo/DateTimeFormatInfoAbbreviatedMonthGenitiveNames.cs

[ahsonkhan]

the code under CoreLib is not live, it is mirrored from the coreclr repo (it is not used for testing either -- just code reuse in some cases). Instead please make a PR with the fix in

This doc might help provide some context: https://github.com/dotnet/coreclr/blob/master/Documentation/project-docs/adding_new_public_apis.md

From #33581 (comment)

The details are explained in https://github.com/dotnet/coreclr/blob/master/Documentation/project-docs/adding_new_public_apis.md. The doc talks about adding new APIs, but it applies for bug fixes in the existing APIs as well.

[jkotas]

The new link to doc: https://github.com/dotnet/coreclr/blob/master/Documentation/project-docs/changing-corelib.md

[tarekgh]

@lillo42 I am not seeing you opened a PR in coreclr repo. are you going to do that? please link it to this one when you open it. and let's if you need any help. thanks for fixing this issue,

[lillo42]

@tarekgh sorry for delay to open PR, I opened, do you need the number of PR?

[tarekgh]

thanks @lillo42 I already looked at the other PR. Just revert the git ignore file there as it is not related to the change we are doing.

[lillo42]

@tarekgh Should I copy changes I've do on CoreCLR to this Repository? Can I use this PR or create another PR ?

[tarekgh]

@lillo42 you just need to wait the coreclr package that has your changes come to corefx. watch the PR's similar to #33783. such PR's is used to bring the new coreclr builds to corefx.

for code mirroring, this will happen automatically.

[ahsonkhan]

@dotnet-bot test this please

[tarekgh]

test this please

[tarekgh]

test NETFX x86 Release Build

[tarekgh]

@lillo42 the still still failing.

Unhandled Exception of Type Xunit.Sdk.EqualException
Message :
Assert.Equal() Failure
             ↓ (pos 3)
Expected: 19 GenJun 76
Actual:   19 Jun 76
             ↑ (pos 3)
Stack Trace :
   at System.Globalization.Tests.DateTimeFormatInfoAbbreviatedMonthGenitiveNames.AbbreviatedMonthNames_Format() in D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Globalization\tests\DateTimeFormatInfo\DateTimeFormatInfoAbbreviatedMonthGenitiveNames.cs:line 44

[lillo42]

@tarekgh continue fail, but another test, should I merge branch master :

Windows.10.Amd64.ClientRS4.Open-x86-Release
ThreadPoolScheduler_SchedulesOnThreadPool

Unhandled Exception of Type Xunit.Sdk.NotEqualException
Message :

Assert.NotEqual() Failure
Expected: Not 10 Actual: 10

Stack Trace :

--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.IO.Pipelines.Tests.SchedulerFacts.<ThreadPoolScheduler_SchedulesOnThreadPool>d__11.MoveNext() in D:\j\workspace\windows-TGrou---2a8f9c29\src\System.IO.Pipelines\tests\SchedulerFacts.cs:line 542
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) ```

[jkotas]

This failure is unrelated to your change. Opened https://github.com/dotnet/corefx/issues/33937 on it.

[jkotas]

@dotnet-bot test NETFX x86 Release Build please

[tarekgh]

Thanks @lillo42 for submitting these PR's. and thanks @jkotas for your help.