This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Clean up Unix Domain Sockets example #5441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate the type out into its own file, to make it easier for others to consume - Fix a bug that prohbited it from being used with Accept (removed min length validation in ctor) - Added a test that does Connect/Accept and Send/Receive - A few other cleanups in the existing tests
Contributor
|
LGTM |
Contributor
There was a problem hiding this comment.
Are you sure UTF-8 is appropriate here? Maybe ASCII? It's not clear to me from the man page how this should be handled...
Member
Author
There was a problem hiding this comment.
Most encoding on Unix systems defaults to UTF8. Unless otherwise stated, I believe it's the right choice.
Contributor
|
LGTM, assuming UTF-8 is the right encoding. |
Member
Author
|
Thanks, guys. |
Contributor
|
LGTM as well. UTF8 is correct AFAIK. |
stephentoub
added a commit
that referenced
this pull request
Jan 15, 2016
Clean up Unix Domain Sockets example
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Clean up Unix Domain Sockets example Commit migrated from dotnet/corefx@97c00f6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-on to #5051, fixes #4588.
cc: @IlyaBiryukov, @pgavlin, @ericeil