This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Use nameof in System.Composition.* #6267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| Requires.NotNull(parameter, "reflectedType"); | ||
| Requires.NotNull(parameter, "parameter"); | ||
| Requires.NotNull(reflectedType, nameof(reflectedType)); |
Member
There was a problem hiding this comment.
While I'm sure this is what was originally intended, are we going to start failing in places we didn't previously?
Contributor
Author
There was a problem hiding this comment.
True. I'm going to just remove the reflectedType null check here as later uses of reflectedType guard against it being null (but don't throw) and it never threw for null before (which would be a breaking change as you point out).
Member
|
One concern, otherwise LGTM. |
Mostly automated replacement of parameter name string literals with corresponding usage of nameof.
justinvp
force-pushed
the
nameof_composition
branch
from
51e5f93 to
3b165eb
Compare
This was referenced Feb 20, 2016
Member
|
LGTM |
stephentoub
added a commit
that referenced
this pull request
Feb 20, 2016
Use nameof in System.Composition.*
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Use nameof in System.Composition.* Commit migrated from dotnet/corefx@4c2f79e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly automated replacement of parameter name string literals with corresponding usage of
nameof(via a modified version of @jaredpar's https://github.com/jaredpar/UseNameOf) along the lines of #6209 and #6265.cc: @stephentoub, @dsplaisted