Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@leemgs
Copy link

@leemgs leemgs commented Mar 2, 2016

This patch resolves the build folder of managed corefx for release mode
on Ubuntu 14.04 64bit pc and Windows 7 pc

leemgs and others added 2 commits March 2, 2016 14:52
Using the cross build process of coreclr, enable cross building
of native corefx components for Ubuntu 14.04 ARM target.
(e.g. u14.04$> ROOTFS_DIR=/work/dotnet/rootfs-corefx/arm \
		./build.sh native arm clean cross )

Signed-off-by: MyungJoo Ham <[email protected]>
Signed-off-by: Geunsik Lim <[email protected]>
Signed-off-by: Prajwal A N <[email protected]>
We can build managed corefx with debug mode (by default) on Ubuntu 14.04 PC.
Although we run "corefx@u14$> build.sh managed release clean" command to build
managed corefx with release mode, the 'build.sh' script generates
"./bin/AnyOS.AnyCPU.Debug" folder instead of "AnyOS.AnyCPU.Release" folder.
This patch resolves the build folder of managed corefx for release mode on
Ubuntu 14.04 64bit pc and Windows 7 pc.

Signed-off-by: Geunsik Lim <[email protected]>
Signed-off-by: Prajwal A N <[email protected]>
Signed-off-by: MyungJoo Ham <[email protected]>
@dnfclas
Copy link

dnfclas commented Mar 2, 2016

Hi @leemgs, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@stephentoub
Copy link
Member

Thanks, @leemgs. Did you mean to include c201972? Looks like that's the same commit from PR #6585, so I assume the only commit meant for this PR is df390b1.

@stephentoub
Copy link
Member

Commit df390b1 LGTM.

cc: @ellismg, @mellinoe, @joperezr

@leemgs
Copy link
Author

leemgs commented Mar 2, 2016

so I assume the only commit meant for this PR is df390b1.

Right.

@dnfclas
Copy link

dnfclas commented Mar 2, 2016

@leemgs, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@mellinoe
Copy link
Contributor

mellinoe commented Mar 2, 2016

Commit df390b1 LGTM.

Yes, this looks good to me as well.

stephentoub added a commit that referenced this pull request Mar 2, 2016
Resolve build folder of managed corefx on Ubuntu 14.04 in  release mode.
@stephentoub stephentoub merged commit 5789152 into dotnet:master Mar 2, 2016
@karelz karelz modified the milestone: 1.0.0-rtm Dec 3, 2016
macrogreg pushed a commit to open-telemetry/opentelemetry-dotnet-instrumentation that referenced this pull request Sep 24, 2020
Resolve build folder of managed corefx on Ubuntu 14.04 in  release mode.

Commit migrated from dotnet/corefx@5789152
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Resolve build folder of managed corefx on Ubuntu 14.04 in  release mode.

Commit migrated from dotnet/corefx@5789152
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants