This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix off-by-one similar to #6819 in other cases. #6843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend tests to cover both those and other places it could occur even if it currently doesn't.
Make the inclusive nature of the boundaries more explicit in the code.
dotnet-bot
changed the title
Contributor
Author
|
Test Innerloop CentOS7.1 Release Build and Test. please. |
Contributor
Author
|
Test Innerloop CentOS7.1 Debug Build and Test, please. |
Member
|
LGTM. Thanks. |
stephentoub
added a commit
that referenced
this pull request
Mar 12, 2016
Fix off-by-one similar to #6819 in other cases.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Fix off-by-one similar to dotnet/corefx#6819 in other cases. Commit migrated from dotnet/corefx@c877993
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6842
Also extend tests to cover both those and other places it could occur even if it currently doesn't.
Further, name min/max index fields as inclusive as @stephentoub suggested, making the inclusive nature of the boundaries more explicit in the code.
Likely easier to review a commit at a time, as otherwise the fixes get lost in the name changes.
cc: @stephentoub @VSadov