This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Implement SocketPal.Poll on Unix with poll instead of select #6846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SocketPal.Poll on Unix is currently implemented with select. This is causing problems due to limitations of select, which fails with file descriptors >= FD_SETSIZE. I've changed the implementation to use poll instead, which both fixes the problem and results in simpler code. I've also added a few tests, and in the process of doing so cleaned up some related tests to use theories.
stephentoub
force-pushed
the
socket_poll
branch
from
6954bed to
11881a6
Compare
Member
Author
stephentoub
added a commit
that referenced
this pull request
Mar 14, 2016
Implement SocketPal.Poll on Unix with poll instead of select
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Implement SocketPal.Poll on Unix with poll instead of select Commit migrated from dotnet/corefx@b866f52
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SocketPal.Poll on Unix is currently implemented with select. This is causing problems due to limitations of select, which fails with file descriptors >= FD_SETSIZE. I've changed the implementation to use poll instead, which both fixes the problem and results in simpler code. I've also added a few tests, and in the process of doing so cleaned up some related tests to use theories.
This is blocking #6833, which in CI is frequently getting file descriptors for sockets larger than FD_SETSIZE.
cc: @ericeil, @pgavlin, @davidsh, @CIPop
Contributes to #4728.