This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix SqlParameter Validation for Enum Type. #7004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
This will fix this issue https://github.com/dotnet/corefx/issues/1613 |
|
|
||
| if (dataType == typeof (System.Byte[])) | ||
| { | ||
| // mdac 90455 must not default to image if inferLen is false ... |
Contributor
There was a problem hiding this comment.
This comment should be removed.
Contributor
|
@dotnet-bot Test Innerloop Windows_NT Release Build and Test please |
Contributor
|
@kkurni There are some comments which need to be cleaned up. Otherwise LGTM. |
This logic is the same as .net 4.5 but it use Convert.GetTypeCode instead of Type.GetTypeCode.
kkurni
added a commit
that referenced
this pull request
Mar 18, 2016
Fix SqlParameter Validation for Enum Type.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert back the logic as close as current net framework.
Because it doesn't count if the the type is enum.
In corefx, we cannot get GetTypeCode from Type. But we can get this from the value/instance by using Convert.GetTypeCode(value).
If it is enum type, Convert.GetTypeCode will called IConvertible.GetTypeCode which implemented in Enum Type to get the underlying type.